Contact info widget: ensure the map response has results

[eliorivero]

This fixes #12913 by checking not only that the status is correct, but also if the response has results before attempting to use their geometric data.

May be superseeded by #12474

Changes proposed in this Pull Request:

• check that the array of results is not empty

Testing instructions:

• Go to /wp-admin/widgets.php
• Add a Contact info widget to the footer
• ensure there are no notices in wp-content/debug.log
• alternatively check the JS console. This was also causing errors visible in the ajax response.

Proposed changelog entry for your changes:

• Not needed.

[eliorivero]

While this PR solves this, the error is due to Google blocking the request. The complete error response is:

[02-Jul-2019 15:49:25 UTC] stdClass Object
(
    [error_message] => You must use an API key to authenticate each request to Google Maps Platform APIs. For additional information, please refer to http://g.co/dev/maps-no-account
    [results] => Array
        (
        )

    [status] => REQUEST_DENIED
)

Perhaps we should consider letting the user know what is going on? There's message in the widget saying that it's not working normally as it should.

cc @MichaelArestad

[jetpackbot]

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: August 6, 2019.
Scheduled code freeze: July 30, 2019

Generated by 🚫 dangerJS against 398d3ac

[jeherve]

Perhaps we should consider letting the user know what is going on? There's message in the widget saying that it's not working normally as it should.

#12474 should improve the user experience in that regard.

[jeherve]

This looks good to me. I would hold on that PR though, and see if we can focus on #12474 instead, as it will also solve the issue by getting rid of that part of the code altogether.