Sync: ensure we can calculate a histogram for term relationships #13057
Conversation
This is an automated check which relies on |
| case 'term_relationships': | ||
| $object_table = $wpdb->term_relationships; | ||
| $object_count = $this->term_relationship_count(); | ||
| $id_field = 'object_id'; |
There was a problem hiding this comment.
The object_id column isn't really a unique ID, so we can't use it for identifying a particular row. It's as much of a ID field as the term taxonomy ID. Should we be concerned about this? Should we be able to calculate histogram for tables that lack a unique ID field?
I'm basically concerned for cases when we have 1000 term relationships for 1 post, and then 1 term relationship per post after that. It just feels like it's not a reliable way to limit terms.
What do you think? Should we use some sort of calculation of both IDs?
roccotripaldi
added
[Status] In Progress
and removed
[Status] Needs Review
|
Will revisit this with a different approach now that #13077 is open |
Fixes an issue where we cannot validate a site whose terms are out of sync
Changes proposed in this Pull Request:
Is this a new feature or does it add/remove features to an existing part of Jetpack?
Testing instructions:
Proposed changelog entry for your changes: