Unit Tests: Fix WooCommerce tests bootstrap #13080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Bug
Collaborator
This is an automated check which relies on |
roccotripaldi
approved these changes
Jul 18, 2019
Contributor
roccotripaldi
left a comment
roccotripaldi
left a comment
There was a problem hiding this comment.
I get this error when running the tests:
Fatal error: Declaration of WC_Unit_Test_Case::assertNotFalse($condition, $message = '') must be compatible with WP_UnitTestCase::assertNotFalse($condition, string $message = ''): void in /var/www/html/wp-content/plugins/woocommerce/tests/framework/class-wc-unit-test-case.php on line 145
I think it's not related to this PR, I can bypass the error by deleting Woo's declaration of assertNotFalse and then all Jetpack Woo tests pass. I say we ship it!
jeherve
added
[Status] Ready to Merge
jeherve
approved these changes
Jul 18, 2019
Member
jeherve
left a comment
jeherve
left a comment
There was a problem hiding this comment.
Same as Rocco (discussion in p1563462564245100-slack-jetpack-crew). Let's merge this!
matticbot
added
[Status] Needs Changelog
and removed
[Status] Ready to Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, WooCommerce tests are broken. We tried to add some test cases in #13079, but we were unable to run the tests.
The reason seems to be simple: our WooCommerce tests have a hardcoded bit where they load files from the WooCommerce test framework (borrowed from their unit test bootstrap), and some of the file names were obsolete.
This PR fixes those by using the includes from the latest WooCommerce master.
Changes proposed in this Pull Request:
Is this a new feature or does it add/remove features to an existing part of Jetpack?
Needed for #13079.
Testing instructions:
/docker/wp-content/plugins/woocommerce, and WooCommerce is built (composer install,npm install,npm run buildin the woo dir does the job).yarn docker:shcd wp-content/plugins/jetpackJETPACK_TEST_WOOCOMMERCE=1 phpunit --filter WP_Test_Jetpack_Sync_WooCommerceProposed changelog entry for your changes: