Skip to content

Conversation

@simison
Copy link
Member

@simison simison commented Jul 24, 2019

Adds missing core dependencies in wpcom-block-editor module.

I noticed files in Calypso's /apps/wpcom-block-editor/src/common and /apps/wpcom-block-editor/src/calypso are importing from some core deps that weren't listed as dependencies in PHP side.

In practise these get enqueued in the editor currently anyway so nothing should change per-se. :-) It's just good practice and safer.

Common script was missing these

  • jquery (#)
  • wp-blocks (#)
  • wp-dom-ready (#)
  • wp-nux (#)
  • wp-plugins (#)

Added to both common- and calypso-scripts

  • wp-polyfill — build process doesn't include Babel/polyfill for these files so to make sure things work in IE11, you'll need to ensure it's enqueued.

Changes proposed in this Pull Request:

  • Adds wp core deps

Testing instructions:

Open the block editor both in Jetpack self hosted's wp-admin as well via Calypso and confirm that everything still works as expected.

Proposed changelog entry for your changes:

@simison simison added [Status] Needs Review This PR is ready for review. [Type] Janitorial labels Jul 24, 2019
@simison simison added this to the 7.6 milestone Jul 24, 2019
@simison simison requested review from a team July 24, 2019 09:58
@jetpackbot
Copy link
Collaborator

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: August 6, 2019.
Scheduled code freeze: July 30, 2019

Generated by 🚫 dangerJS against 8491ead

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Jul 24, 2019
@simison simison merged commit 3d9f9f3 into master Jul 26, 2019
@simison simison deleted the update/add-missing-wp-deps branch July 26, 2019 12:52
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Jul 26, 2019
emilyatmobtown pushed a commit to emilyatmobtown/jetpack that referenced this pull request Jul 26, 2019
@sirreal
Copy link
Member

sirreal commented Jul 30, 2019

We could run the build with the extern plugin and grab the deps.json for these files to validate the dependencies.

I wonder if the dependencies should be committed on WPCOM and synced to Jetpack 🤔

@simison
Copy link
Member Author

simison commented Jul 30, 2019

On .com these are part of a separate gutenberg-wpcom plugin which is not synced with Jetpack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants