wpcom block editor: add missing wp deps #13122
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds missing core dependencies in
wpcom-block-editormodule.I noticed files in Calypso's
/apps/wpcom-block-editor/src/commonand/apps/wpcom-block-editor/src/calypsoare importing from some core deps that weren't listed as dependencies in PHP side.In practise these get enqueued in the editor currently anyway so nothing should change per-se. :-) It's just good practice and safer.
Common script was missing these
jquery(#)wp-blocks(#)wp-dom-ready(#)wp-nux(#)wp-plugins(#)Added to both common- and calypso-scripts
wp-polyfill— build process doesn't include Babel/polyfill for these files so to make sure things work in IE11, you'll need to ensure it's enqueued.Changes proposed in this Pull Request:
Testing instructions:
Open the block editor both in Jetpack self hosted's wp-admin as well via Calypso and confirm that everything still works as expected.
Proposed changelog entry for your changes: