-
Notifications
You must be signed in to change notification settings - Fork 846
Sync certain options updated via WPCLI instantly #13132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is an automated check which relies on |
|
This seems reasonable. I was not able to test because I was not able to get this branch running on a non-local site. If i were to test, i would do so by running your recommended command, and ensuring a sync happens immediately, and by trying a few other WP CLI commands and ensuring that a sync does not happen immediately. |
lezama
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
didn't test, but looks sane
tyxla
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sync certain options updated via WPCLI instantly
This PR ensures that certain options updated via WP CLI sync instantly.
Testing instructions:
From a non-docker site (since it will only sync
localhostas home option):Try
wp option update siteurl https://my-new-domain3.comandwp option update home https://my-new-domain3.com,make sure both come through on your wpcom sandbox right away.
Change the domain values so they're eligible to sync and try again. They should sync right away.