Skip to content

Conversation

@gititon
Copy link
Contributor

@gititon gititon commented Jul 25, 2019

This PR ensures that certain options updated via WP CLI sync instantly.

Testing instructions:
From a non-docker site (since it will only sync localhost as home option):

Try
wp option update siteurl https://my-new-domain3.com and
wp option update home https://my-new-domain3.com,
make sure both come through on your wpcom sandbox right away.

Change the domain values so they're eligible to sync and try again. They should sync right away.

@gititon gititon added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Package] Sync labels Jul 25, 2019
@gititon gititon added this to the 7.6 milestone Jul 25, 2019
@gititon gititon requested review from a team July 25, 2019 23:00
@gititon gititon self-assigned this Jul 25, 2019
@jetpackbot
Copy link
Collaborator

Warnings
⚠️

The PR is missing at least one [Status] label. Suggestions: [Status] In Progress, [Status] Needs Review

⚠️ "Proposed changelog entry" is missing for this PR. Please include any meaningful changes

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against d538e9d

@roccotripaldi
Copy link
Contributor

This seems reasonable.

I was not able to test because I was not able to get this branch running on a non-local site.
The branch is not appearing as an option in the beta testing plugin.

If i were to test, i would do so by running your recommended command, and ensuring a sync happens immediately, and by trying a few other WP CLI commands and ensuring that a sync does not happen immediately.

Copy link
Contributor

@lezama lezama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't test, but looks sane

Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gititon gititon merged commit 5e45c6d into master Jul 26, 2019
@gititon gititon deleted the wp-cli-sync-site-url branch July 26, 2019 13:25
@matticbot matticbot removed the [Status] Needs Review This PR is ready for review. label Jul 26, 2019
emilyatmobtown pushed a commit to emilyatmobtown/jetpack that referenced this pull request Jul 26, 2019
Sync certain options updated via WPCLI instantly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Package] Sync [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants