Skip to content

Tests: Core now caches API Endpoint Schemas. Flush that cache. #13245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdawaffe merged 3 commits into from
Aug 16, 2019
Merged

Tests: Core now caches API Endpoint Schemas. Flush that cache. #13245

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b2fb539
Publicize: Also test that post_type=post has the publicize message me…
mdawaffe Aug 16, 2019
b617e04
Tests: Core now caches API Endpoint Schemas. Flush that cache.
mdawaffe Aug 16, 2019
b6d738d
Tests: `->tearDown()` should be in reverse order of `->setUp()`.
mdawaffe Aug 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 32 additions & 6 deletions tests/php/core-api/wpcom-fields/test-post-fields-publicize-connections.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,23 +118,47 @@ public function setUp() {
// phpunit --group=rest-api
$this->publicize = publicize_init();
$this->publicize->register_post_meta();
}

public function tearDown() {
$this->teardown_fields();

parent::tearDown();
// Flush the schema cache for those Posts Controllers that need it.
// https://core.trac.wordpress.org/changeset/45811/
$GLOBALS['wp_rest_server']->override_by_default = true;
foreach ( get_post_types() as $post_type ) {
if ( ! $this->publicize->post_type_is_publicizeable( $post_type ) ) {
continue;
}

wp_delete_post( $this->draft_id, true );
$controller = new WP_REST_Posts_Controller( $post_type );
$controller->register_routes();
}
$GLOBALS['wp_rest_server']->override_by_default = false;
}

public function tearDown() {
$publicizeable_post_types = [];
// Clean up custom meta from publicizeable post types
foreach ( get_post_types() as $post_type ) {
if ( ! $this->publicize->post_type_is_publicizeable( $post_type ) ) {
continue;
}

$publicizeable_post_types[] = $post_type;
unregister_meta_key( 'post', $this->publicize->POST_MESS, $post_type );
}

// Flush the schema cache for those Posts Controllers that need it.
// https://core.trac.wordpress.org/changeset/45811/
$GLOBALS['wp_rest_server']->override_by_default = true;
foreach ( $publicizeable_post_types as $post_type ) {
$controller = new WP_REST_Posts_Controller( $post_type );
$controller->register_routes();
}
$GLOBALS['wp_rest_server']->override_by_default = false;

$this->teardown_fields();

parent::tearDown();

wp_delete_post( $this->draft_id, true );
}

private function setup_fields() {
Expand Down Expand Up @@ -180,6 +204,8 @@ public function test_register_fields_posts() {
$schema = $data['schema'];

$this->assertArrayHasKey( 'jetpack_publicize_connections', $schema['properties'] );
$this->assertArrayHasKey( 'meta', $schema['properties'] );
$this->assertArrayHasKey( 'jetpack_publicize_message', $schema['properties']['meta']['properties'] );
}

public function test_register_fields_custom_post_type_with_custom_fields_support() {
Expand Down