Update is_fse_active to account for a8c_disable_full_site_editing filter

[gwwar]

Sometimes we may want to disable full site editing flows in the page editor, but still have access to other features like the post list or start page templates. This is done with the following filter:

add_filter( 'a8c_disable_full_site_editing', '__return_true' );

Changes here update the /sites/mysite endpoint to return site.is_fse_active false when the a8c_disable_full_site_editing returns true.

Testing Instructions

• Create a new test site https://jurassic.ninja/create?branch=update/fse-is-actives&jetpack-beta
• Install the Full Site Editing Plugin, Gutenberg development plugin and activate both
• Install Modern Business from https://github.com/Automattic/themes/
• Verify that is_fse_active is true, and that Full Site Editing flows are available when editing a page.

Add the following filter to the site, can be done easily in the plugin editor:

add_filter( 'a8c_disable_full_site_editing', '__return_true' );

• site response should be is_fse_active false,
• FSE flows for the post editor are not available, but other features still are like Starter Page Templates and Recent Blog Posts

Notice no header/footer, just the plain block editor:

We still have access to Starter Page Templates

With the filter added we see is_fse_active is false:

Part of fixing Automattic/wp-calypso#35854

[jetpackbot]

	Warnings
⚠️	"Testing instructions" are missing for this PR. Please add some
⚠️	"Proposed changelog entry" is missing for this PR. Please include any meaningful changes

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against 4b4c6bf

[gwwar]

Related on the wpcom side is D32356-code

[jeherve]

I'd be happy with a docblock here to keep our Codex parser happy. It would also help explain what the filter is going to be used for, as I think it may be a bit confusing for non-a12s right now.

Here is an example:

jetpack/sal/class.json-api-site-base.php

Lines 115 to 124 in b999369

	/**
	* Filter if a site is an automated-transfer site.
	*
	* @module json-api
	*
	* @since 6.4.0
	*
	* @param bool is_automated_transfer( $this->blog_id )
	* @param int $blog_id Blog identifier.
	*/

[gwwar]

Will do, thanks!

[gwwar]

Note that /me/sites is_fse_active is still true with add_filter( 'a8c_disable_full_site_editing', '__return_true' ); but I'll try and update that case in D32356-code

[gwwar]

Thanks for the fixes @glendaviesnz, I've verified the testing flow, and updated the summary to help other reviewers.

[jeherve]

Works well for me. Merging.

[jeherve]

Cherry-picked to branch-7.7 in 9ac6d2d

[gwwar]

Thanks @jeherve !