Skip to content

Conversation

@crunnells
Copy link
Contributor

Changes the page navigation so links are shown in a vertical list instead of inline (for better readability), and fix the search box so it's always next to the dropdown and flexes with the browser window width.

Fixes Automattic/wp-calypso#32406

Changes proposed in this Pull Request:

  • Fixes the Calypsoify filter menu on the Plugin install page

Before:
image

After:
image

Testing instructions:

  • On a mobile view (screen width < 480px), enable Calypsoify on your local site (add ?calypsoify=1 to your site's URL)
  • Visit the Add Plugin page, notice the filter links (Featured, Popular, Recommended, Favorites) are now in a vertical list instead of inline

Proposed changelog entry for your changes:

  • Fixes the Calypso-ified mobile view of the filter menu on the Plugin install page

Changes the page navigation so links are shown in a vertical list instead of inline (for better readability), and fix the search box so it's always next to the dropdown and flexes with the browser window width.
@crunnells crunnells requested a review from a team September 13, 2019 15:58
@jetpackbot
Copy link
Collaborator

Warnings
⚠️

The PR is missing at least one [Status] label. Suggestions: [Status] In Progress, [Status] Needs Review

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against 5739663

@crunnells crunnells self-assigned this Sep 13, 2019
@jeherve jeherve added the [Type] Bug When a feature is broken and / or not performing as intended label Sep 13, 2019
@jeherve jeherve added this to the 7.8 milestone Sep 13, 2019
Copy link
Contributor

@scottsweb scottsweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, nice improvement.

@scottsweb scottsweb added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Sep 13, 2019
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Merging.

@jeherve jeherve merged commit f7d75ea into master Sep 13, 2019
@jeherve jeherve deleted the fix/issue-32406 branch September 13, 2019 16:48
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Sep 13, 2019
jeherve added a commit that referenced this pull request Sep 24, 2019
jeherve added a commit that referenced this pull request Sep 24, 2019
* Changelog: initial set of changes for 7.8

* Changelog: add #13310

* Changelog: add #13103

* Changelog: add #13426

* Changelog: add #13389

* Changelog: add #13449

* Changelog: add #13461

* Changelog: add #13460

* Changelog: add #13441

* Changelog: add #13454

* Changelog: add #13457

* Changelog: add #13425

* Changelog: add #13473

* Changelog: add #13355

* Changelog: add #13451

* Changelog: add #13358

* Changelog: add #13464

* Changelog: add #13416

* Changelog: add #13494

* Changelog: add #13465

* Changelog: add #13424

* Changelog: add #13432

* Changelog: add #13471

* Changelog: add 7.7.2 entry

* Changelog: add #13446

* Add more testing elements
jeherve added a commit that referenced this pull request Sep 24, 2019
* Changelog: initial set of changes for 7.8

* Changelog: add #13310

* Changelog: add #13103

* Changelog: add #13426

* Changelog: add #13389

* Changelog: add #13449

* Changelog: add #13461

* Changelog: add #13460

* Changelog: add #13441

* Changelog: add #13454

* Changelog: add #13457

* Changelog: add #13425

* Changelog: add #13473

* Changelog: add #13355

* Changelog: add #13451

* Changelog: add #13358

* Changelog: add #13464

* Changelog: add #13416

* Changelog: add #13494

* Changelog: add #13465

* Changelog: add #13424

* Changelog: add #13432

* Changelog: add #13471

* Changelog: add 7.7.2 entry

* Changelog: add #13446

* Add more testing elements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Calypsoify [Type] Bug When a feature is broken and / or not performing as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Calypsoify: The tabs for plugin search respond poorly on mobile.

6 participants