Skip to content

Build Workflow: rely on COMPOSER_MIRROR_PATH_REPOS for packages #13488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dereksmart merged 1 commit into from
Sep 16, 2019
Merged

Build Workflow: rely on COMPOSER_MIRROR_PATH_REPOS for packages #13488

dereksmart merged 1 commit into from
Sep 16, 2019

Conversation

@jeherve
Copy link
Member

@jeherve jeherve commented Sep 16, 2019

Related: #12480

Changes proposed in this Pull Request:

  • When buidling the production version of the plugin, make sure we do not mirror the packages, but pull them.

Testing instructions:

  • The workflow should work.

Proposed changelog entry for your changes:

  • None

@jeherve jeherve added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Review This PR is ready for review. [Type] Janitorial labels Sep 16, 2019
@jeherve jeherve added this to the 7.8 milestone Sep 16, 2019
@jeherve jeherve requested review from a team and dereksmart September 16, 2019 22:10
@jeherve jeherve self-assigned this Sep 16, 2019
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Sep 16, 2019
@jetpackbot
Copy link
Collaborator

jetpackbot commented Sep 16, 2019

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: October 1, 2019.
Scheduled code freeze: September 24, 2019

Generated by 🚫 dangerJS against 2617f9d

@dereksmart dereksmart merged commit c0f615d into master Sep 16, 2019
@dereksmart dereksmart deleted the update/build-workflow-run branch September 16, 2019 22:23
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Sep 16, 2019
@jeherve jeherve added the Actions GitHub actions used to automate some of the work around releases and repository management label Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dereksmart dereksmart dereksmart approved these changes

Assignees

@jeherve jeherve

Labels

Actions GitHub actions used to automate some of the work around releases and repository management [Type] Bug When a feature is broken and / or not performing as intended [Type] Janitorial

Projects

None yet

Milestone

7.8

Development

Successfully merging this pull request may close these issues.

5 participants

@jeherve @jetpackbot @dereksmart @matticbot