Skip to content

Conversation

@kraftbj
Copy link
Contributor

@kraftbj kraftbj commented Oct 17, 2019

Eventually, this can be merged to set PHP 7.4 as the default environment for Jetpack, but while PHP 7.4 is still in development, this branch can be used for testing Jetpack to find more places for us to improve 7.4 compat.

Changes proposed in this Pull Request:

  • Updates docker to use php 7.4.

Is this a new feature or does it add/remove features to an existing part of Jetpack?

  • p9dueE-11V-p2

Testing instructions:

  • yarn docker:clean && yarn docker:up (or docker:ngrok-up)
  • Use WP and Jetpack
  • Review docker/logs/php/errors.log
  • Any from Jetpack? Create new issues or PRs to resolve.

Proposed changelog entry for your changes:

@jetpackbot
Copy link
Collaborator

jetpackbot commented Oct 17, 2019

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: January 14, 2020.
Scheduled code freeze: January 7, 2020

Generated by 🚫 dangerJS against 451f0dd

@simison
Copy link
Member

simison commented Oct 21, 2019

The best would be to have a flexible setup where we could switch PHP version "on the fly" and it would only change one image.

Prior art: #9252

@kraftbj kraftbj added [Status] Needs Review This PR is ready for review. and removed DO NOT MERGE don't merge it! [Status] In Progress labels Dec 5, 2019
@kraftbj kraftbj self-assigned this Dec 5, 2019
@kraftbj kraftbj added this to the 8.1 milestone Dec 5, 2019
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Dec 6, 2019
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to work well for me, it should be good to merge.

I stumbled across some notices, opened #14192.

@kraftbj kraftbj merged commit 23be5c8 into master Dec 6, 2019
@kraftbj kraftbj deleted the update/docker-7.4 branch December 6, 2019 23:32
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants