Skip to content

Sharing settings: bail early if General settings can't be foun… #13971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kraftbj merged 1 commit into from
Nov 7, 2019
Merged

Sharing settings: bail early if General settings can't be foun… #13971

kraftbj merged 1 commit into from
Nov 7, 2019

Conversation

@jeherve
Copy link
Member

@jeherve jeherve commented Nov 6, 2019

Changes proposed in this Pull Request:

  • Still waiting on some more information, but it seems that in some cases $submenu['options-general.php'] may not exist on some sites.

See https://wordpress.org/support/topic/warning-notice-undefined-index-options-general-php/

Testing instructions:

  • With this patch on, disable Publicize, Sharing, Likes, and Comment Likes on your site.
  • Go to Jetpack > Settings > Traffic
  • Try to automatically verify your site with Google.
  • The pop up that opens should lead you to Google.

Proposed changelog entry for your changes:

  • Site Verification Tools: avoid PHP warnings when using plugins to modify the WordPress admin menu.

@jeherve jeherve added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Sharing Post sharing, sharing buttons [Feature] Verification tools [Status] Needs Review This PR is ready for review. [Pri] High labels Nov 6, 2019
@jeherve jeherve added this to the 8.0 milestone Nov 6, 2019
@jeherve jeherve requested review from a team and kraftbj November 6, 2019 14:12
@jeherve jeherve self-assigned this Nov 6, 2019
@jetpackbot
Copy link
Collaborator

jetpackbot commented Nov 6, 2019

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: December 3, 2019.
Scheduled code freeze: November 26, 2019

Generated by 🚫 dangerJS against ad8c5d6

@jeherve jeherve modified the milestones: 8.0, 7.9.1 Nov 6, 2019
@kraftbj kraftbj changed the title Sharing settings: bail early if General settings can't be found. Sharing settings: bail early if General settings can't be foun… Nov 7, 2019
@kraftbj kraftbj merged commit 0bade54 into master Nov 7, 2019
@kraftbj kraftbj deleted the fix/notices-general-options branch November 7, 2019 23:14
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Needs Review This PR is ready for review. labels Nov 7, 2019
jeherve added a commit that referenced this pull request Nov 8, 2019
@jeherve
Changelog: add #13971
640e99b
@jeherve
Copy link
Member Author

jeherve commented Nov 8, 2019

Cherry-picked to branch-7.9 in 427434f

jeherve added a commit that referenced this pull request Nov 8, 2019
@jeherve
[not verified] Sharing settings: bail early if General settings can't…
427434f 
… be foun… (#13971)
jeherve added a commit that referenced this pull request Nov 15, 2019
@jeherve
Changelog: add #13971
1bf96da
jeherve added a commit that referenced this pull request Nov 25, 2019
@jeherve
8.0 Release: running changelog (#13964)
807ab89 
* 8.0 Release: running changelog

* Changelog: add #13921

* Changelog: add #13980

* Changelog: add #13905

* Changelog: add #13971

* Changelog: add #13984

* Changelog: add #14009

* Changelog: add #13620

* Remove things that will ship in 7.9.1

* Changelog: add 7.9.1 release (#14044)

* Changelog: add base for 7.9.1 release

* Update release date and post link

* Changelog: add #14066

* Update changelog for 7.9.1

* Changelog: add #13405

* Changelog: add #13841

* Changelog: add #13924

* Changelog: add #13986

* Changelog: add #14010, #14028, #14053, #14055.

* Changelog: add #14054

* Changelog: add #14031

* Changelog: add #14039

* Changelog: add #14050

* Changelog: add #14070

* Changelog: add #14082

* Changelog: add #14084

* Changelog: add #14111

* Changelog: add #13961

* Changelog: add #14047

* Changelog: add #14091

* Changelog: add #14108

* Changelog: add #14121
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kraftbj kraftbj kraftbj approved these changes

Assignees

@jeherve jeherve

Labels

[Feature] Sharing Post sharing, sharing buttons [Feature] Verification tools [Pri] High [Type] Bug When a feature is broken and / or not performing as intended

Projects

None yet

Milestone

7.9.1

Development

Successfully merging this pull request may close these issues.

5 participants

@jeherve @jetpackbot @kraftbj @matticbot