Skip to content

Pinterest: make the block available to everyone. #14076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jeherve merged 1 commit into from
Nov 25, 2019
Merged

Pinterest: make the block available to everyone. #14076

jeherve merged 1 commit into from
Nov 25, 2019

Conversation

@jeherve
Copy link
Member

@jeherve jeherve commented Nov 19, 2019

Follow up from #13905

Changes proposed in this Pull Request:

  • Now that the block is in Jetpack in Beta, we may need to move it to the list of Stable blocks before the 8.0 Beta release next Tuesday, and we'll need to commit the matching WordPress.com patch on release day on December 3.

@pento What do you think about this? Is this what you had in mind as well, or did you want the block to stay in Beta for another release?

Is this a new feature or does it add/remove features to an existing part of Jetpack?

  • Internal reference: pb5gDS-af-p2

Testing instructions:

  • Go to Posts > Add New on a site connected to WordPres.com and running this branch.
  • You should see the Pinterest block in the block picker without the Beta indicator next to it, and you should still see it even if you don't use JETPACK_BETA_BLOCKS.

Proposed changelog entry for your changes:

  • None

@jeherve jeherve added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review This PR is ready for review. [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Block] Pinterest labels Nov 19, 2019
@jeherve jeherve added this to the 8.0 milestone Nov 19, 2019
@jeherve jeherve requested review from a team and pento November 19, 2019 18:13
@jeherve jeherve self-assigned this Nov 19, 2019
@matticbot
Copy link
Contributor

matticbot commented Nov 19, 2019

Caution: This PR has changes that must be merged to WordPress.com
Hello jeherve! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D35682-code before merging this PR. Thank you!

@jetpackbot
Copy link
Collaborator

jetpackbot commented Nov 19, 2019

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: December 3, 2019.
Scheduled code freeze: November 26, 2019

Generated by 🚫 dangerJS against 04c0054

@pento
Copy link
Contributor

pento commented Nov 20, 2019

Thanks @jeherve!

Do you usually switch a block out of beta before or after the call for testing?

@jeherve
Copy link
Member Author

jeherve commented Nov 21, 2019

Do you usually switch a block out of beta before or after the call for testing?

We've done both. I like doing it before in Jetpack master since it makes testing a bit easier (you have one less step, you don't need to define JETPACK_BETA_BLOCKS)

pento
pento approved these changes Nov 21, 2019
View reviewed changes
Copy link
Contributor

@pento pento left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

zinigor
zinigor approved these changes Nov 25, 2019
View reviewed changes
Copy link
Contributor

@zinigor zinigor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, LGTM as soon as all the tests are passing!

@zinigor zinigor added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Nov 25, 2019
@jeherve jeherve merged commit d0e54c8 into master Nov 25, 2019
@jeherve jeherve deleted the update/pinterest-stable branch November 25, 2019 11:05
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@pento pento pento approved these changes

@zinigor zinigor zinigor approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jeherve jeherve

Labels

[Block] Pinterest [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack Touches WP.com Files [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Projects

None yet

Milestone

8.0

Development

Successfully merging this pull request may close these issues.

6 participants

@jeherve @matticbot @jetpackbot @pento @zinigor