You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #14247 we're merging our instant-search-master branch back into Jetpack master. As part of the review process, we've made a number of fixes. This PR adds those fixes to the instant-search-master branch.
Is this a new feature or does it add/remove features to an existing part of Jetpack?
No - this pulls fixes from another PR into the instant-search-master.
Testing instructions:
If you haven't already, set up Instant Search following the instructions in the readme.
Enter a search query into your site's search input. Ensure that the search results render onto your site's main content area.
pre-commit hook was skipped for one or more commits
This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖
Can we just sync everything that is now in master into instant-search-master? For instance all the php code changes also. Or is that a separate step afterwards?
Yes - we could also just merge everything back from master into instant-search-master after #14247 ships. Just wanted to make sure these changes didn't get forgotten about.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bluefuton
added
[Status] In Progress
[Feature] Search
Changes proposed in this Pull Request:
In #14247 we're merging our
instant-search-masterbranch back into Jetpackmaster. As part of the review process, we've made a number of fixes. This PR adds those fixes to theinstant-search-masterbranch.Is this a new feature or does it add/remove features to an existing part of Jetpack?
No - this pulls fixes from another PR into the
instant-search-master.Testing instructions:
Proposed changelog entry for your changes:
Not required.