Skip to content

Contact Info Block: wrap the phone number link tag in a span #14471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jeherve merged 1 commit into from
Jan 27, 2020
Merged

Contact Info Block: wrap the phone number link tag in a span #14471

jeherve merged 1 commit into from
Jan 27, 2020

Conversation

@kbrown9
Copy link
Member

@kbrown9 kbrown9 commented Jan 24, 2020

Fixes #14298

Changes proposed in this Pull Request:

  • Google's Structured Data doesn't recognize a phone number in a link tag. To fix this, wrap the link tag in a span.

Is this a new feature or does it add/remove features to an existing part of Jetpack?

  • This changes an existing part of Jetpack.

Testing instructions:

Test Site
  • Jetpack must be activated and connected.
Test Steps
  1. Add a Contact Info block with a phone number to a post.
  2. Verify that the phone number displays properly when viewing the post.
  3. Submit the post URL to Google's Structured Data Testing tool at https://search.google.com/structured-data/testing-tool/u/0/
  4. Verify that the telephone number is recognized in the Structured Data test results.

Proposed changelog entry for your changes:

  • tbd

@kbrown9
Contact Info Block: wrap the phone number link tag in a span
9c63cb8 
Google's Structured Data doesn't recognize a phone number in a link tag.
To fix this, wrap the link tag in a span.

Fixes #14298
@kbrown9 kbrown9 added [Type] Bug When a feature is broken and / or not performing as intended [Status] In Progress [Pri] Normal [Block] Contact Info labels Jan 24, 2020
@kbrown9 kbrown9 added this to the 8.2 milestone Jan 24, 2020
@kbrown9 kbrown9 requested a review from a team January 24, 2020 17:53
@kbrown9 kbrown9 self-assigned this Jan 24, 2020
@matticbot
Copy link
Contributor

matticbot commented Jan 24, 2020

Caution: This PR has changes that must be merged to WordPress.com
Hello kbrown9! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D38134-code before merging this PR. Thank you!

@jetpackbot
Copy link
Collaborator

jetpackbot commented Jan 24, 2020

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: February 11, 2020.
Scheduled code freeze: February 4, 2020

Generated by 🚫 dangerJS against 9c63cb8

@kbrown9 kbrown9 added [Status] Needs Review This PR is ready for review. and removed [Status] In Progress labels Jan 24, 2020
jeherve
jeherve approved these changes Jan 27, 2020
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tests well for me. 👍

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Jan 27, 2020
@jeherve jeherve merged commit 20bf727 into master Jan 27, 2020
@jeherve jeherve deleted the fix/ci_block_wrap_tel_link_in_span branch January 27, 2020 10:08
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Jan 27, 2020
@jeherve
Copy link
Member

jeherve commented Jan 27, 2020

r202139-wpcom

jeherve added a commit that referenced this pull request Jan 27, 2020
@jeherve
Changelog: add #14471
ad5b343
jeherve added a commit that referenced this pull request Jan 28, 2020
@jeherve
Changelog: 8.2 release (#14332)
0589a49 
* [not verified] Remove empty readme section

* Initial changelog for 8.2

* Changelog: add #14220

* Changelog: add #14252

* Changelog: add #14291

* Changelog: add #14309

* Changelog: add #14304

* Changelog: add general connection log.

* Changelog: add #14275

* Changelog: add #14313

* Changelog: add #14213

* Changelog: add #14357

* Add sync testing instructions

* Add 8.1.1 changelog back

See eeaafab and 61757eb

* Changelog: add #14371

* Changelog: add #14386

* Changelog: add #14471

* Changelog: add #14325

* Changelog: add #14194

* Changelog: add #14340

* Changelog: add #14418

* Changelog: add #14417

* Changelog: add #14075

* Changelog: add #14467

* Changelog: add #14307

* Changelog: add #14326
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeherve jeherve jeherve approved these changes

Assignees

@kbrown9 kbrown9

Labels

[Block] Contact Info [Pri] Normal Touches WP.com Files [Type] Bug When a feature is broken and / or not performing as intended

Projects

None yet

Milestone

8.2

Development

Successfully merging this pull request may close these issues.

Contact info block: Phone number schema does not appear in stuctured data

5 participants

@kbrown9 @matticbot @jetpackbot @jeherve