Skip to content

Map Block: Deprecate all recently introduced attributes #14871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Copons wants to merge 1 commit into from
Closed

Map Block: Deprecate all recently introduced attributes #14871

Copons wants to merge 1 commit into from

Conversation

@Copons
Copy link
Contributor

@Copons Copons commented Mar 3, 2020

Changes proposed in this Pull Request:

  • Deprecate all recently introduced attributes: mapHeight, scrollToZoom, showFullscreenButton.

This PR serves as a base to try a new Fusion diff including changes from:

Testing instructions:

  • WIP

Proposed changelog entry for your changes:

  • N/A

@Copons
Deprecate Map block attributes missing new ones
57a8632 
- mapHeight
- scrollToZoom
- showFullscreenButton
@Copons Copons added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Review This PR is ready for review. [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Block] Map labels Mar 3, 2020
@Copons Copons requested a review from a team March 3, 2020 18:59
@Copons Copons self-assigned this Mar 3, 2020
@jetpackbot
Copy link
Collaborator

jetpackbot commented Mar 3, 2020

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: April 7, 2020.
Scheduled code freeze: March 31, 2020

Generated by 🚫 dangerJS against 57a8632

@Copons Copons closed this Mar 3, 2020
@Copons Copons deleted the fix/map-block-attributes-migration branch March 3, 2020 22:50
@kraftbj kraftbj removed the [Status] Needs Review This PR is ready for review. label Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Copons Copons

Labels

[Block] Map [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack Touches WP.com Files [Type] Bug When a feature is broken and / or not performing as intended

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Copons @jetpackbot @kraftbj @matticbot