Janitorial: clean up deprecated code

[jeherve]

Changes proposed in this Pull Request:

• Following Docs: add recommendations on how to deprecate code #16433, let's remove all code that was deprecated more than 6 months ago.

I left out everything in the compat package.

Jetpack product discussion

• N/A

Does this pull request change what data or activity we track or use?

• No

Testing instructions:

• Do tests pass?
• There is a lot of code that was touched, so I'd recommend looking at different Jetpack features, the connection process, as well as the matching WordPress.com diff and whether those functions / methods are still used somewhere on WordPress.com.

[test-case-reminder]

Here are some suggested test cases for this PR.

Gutenberg extensions

• Use Core's block editor
• Use latest stable Gutenberg plugin

Blocks

• Tiled Gallery
• Business Hours
• Calendly
• Form
• Contact Info
• Eventbrite
• Google calendar
• Mailchimp
• Map
• OpenTable
• Pinterest
• Podcast player
• Star rating
• Recurring Payments
• Repeat Visitor
• Revue
• Simple Payments
• Slideshow

Extensions

• Publicize
• Likes

Connection

• In-place connection with free plan
• In-place connection with paid plan
• In-place connection with product purchase
• Classic connection. Use Safari, or set a constant JETPACK_SHOULD_NOT_USE_CONNECTION_IFRAME to true
• Disconnect/reconnect connection
• Secondary user connection
• Connection on multisite

If you think that suggestions should be improved please edit the configuration file here. You can also modify/add test-suites to be used in the configuration file.

[jetpackbot]

	Warnings
⚠️	The Privacy section is missing for this PR. Please specify whether this PR includes any changes to data or privacy.
⚠️	pre-commit hook was skipped for one or more commits

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against e03aa9e

[matticbot]

Caution: This PR has changes that must be merged to WordPress.com
Hello jeherve! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D46167-code before merging this PR. Thank you!
This revision will be updated with each commit to this PR

[kraftbj]

I'd like to see about running this realize against the Analyzer to see what might break. This would be a good thing to check it with. :)

[jeherve]

I'd like to see about running this realize against the Analyzer to see what might break

Yes, that'd be nice, but last time I tried I ran out of memory and could not get it to work. @zinigor Do you still have your setup to analyze against all plugins in the directory? Do you think you could run it with this PR?

[zinigor]

Sure thing, I'll run it today and report my findings here.

[jeherve]

Thank you!

[zinigor]

I ran the analyzer, here's the results that it found in the updated WordPress plugins repo:

# Akismet
method_missing,class.akismet-admin.php,1130,"Class static method \Jetpack::load_xml_rpc_client() is missing","\Jetpack::load_xml_rpc_client()"

# Certly Guard
method_missing,class.certly-admin.php,948,"Class static method \Jetpack::load_xml_rpc_client() is missing","\Jetpack::load_xml_rpc_client()"

# Jetpack Subscription Form
method_missing,jetpack-subscription.php,253,"Class static method \Jetpack::load_xml_rpc_client() is missing","\Jetpack::load_xml_rpc_client()"

# Reflect
function_missing,reflect.php,93,"Function migrate() is missing",migrate()
function_missing,reflect.php,142,"Function migrate() is missing",migrate()

# SlimJetpack
method_missing,class.jetpack-cli.php,93,"Class static method \Jetpack::unlink_user($user_id=\null) is missing","\Jetpack::unlink_user($user_id=\null)"
method_missing,class.jetpack-client.php,87,"Class static method \Jetpack::fix_url_for_bad_hosts($url) is missing","\Jetpack::fix_url_for_bad_hosts($url)"
method_missing,modules/videopress/videopress.php,154,"Class static method \Jetpack::load_xml_rpc_client() is missing","\Jetpack::load_xml_rpc_client()"
method_missing,class.jetpack.php,1431,"Class static method \Jetpack::clean_nonces($all=\false) is missing","\Jetpack::clean_nonces($all=\false)"
method_missing,class.jetpack.php,1433,"Class static method \Jetpack::load_xml_rpc_client() is missing","\Jetpack::load_xml_rpc_client()"
method_missing,class.jetpack.php,1469,"Class static method \Jetpack::load_xml_rpc_client() is missing","\Jetpack::load_xml_rpc_client()"
method_missing,class.jetpack.php,1554,"Class static method \Jetpack::fix_url_for_bad_hosts($url) is missing","\Jetpack::fix_url_for_bad_hosts($url)"
method_missing,class.jetpack.php,1554,"Class static method \Jetpack::api_url($relative_url) is missing","\Jetpack::api_url($relative_url)"
method_missing,class.jetpack.php,2754,"Class static method \Jetpack::api_url($relative_url) is missing","\Jetpack::api_url($relative_url)"
method_missing,class.jetpack.php,3115,"Class static method \Jetpack::load_xml_rpc_client() is missing","\Jetpack::load_xml_rpc_client()"
method_missing,class.jetpack.php,3135,"Class static method \Jetpack::load_xml_rpc_client() is missing","\Jetpack::load_xml_rpc_client()"
method_missing,class.jetpack.php,3302,"Class static method \Jetpack::fix_url_for_bad_hosts($url) is missing","\Jetpack::fix_url_for_bad_hosts($url)"
method_missing,class.jetpack.php,3302,"Class static method \Jetpack::api_url($relative_url) is missing","\Jetpack::api_url($relative_url)"
method_missing,class.jetpack.php,3594,"Class static method \Jetpack::load_xml_rpc_client() is missing","\Jetpack::load_xml_rpc_client()"
method_missing,class.jetpack.php,3634,"Class static method \Jetpack::load_xml_rpc_client() is missing","\Jetpack::load_xml_rpc_client()"
method_missing,class.jetpack.php,3881,"Class static method \Jetpack::load_xml_rpc_client() is missing","\Jetpack::load_xml_rpc_client()"
method_missing,class.jetpack-ixr-client.php,15,"Class static method \Jetpack::xmlrpc_api_url() is missing","\Jetpack::xmlrpc_api_url()"
method_missing,class.jetpack-client-server.php,79,"Class static method \Jetpack::update_user_token($user_id,$token,$is_master_user) is missing","\Jetpack::update_user_token($user_id,$token,$is_master_user)"
method_missing,class.jetpack-client-server.php,170,"Class static method \Jetpack::fix_url_for_bad_hosts($url) is missing","\Jetpack::fix_url_for_bad_hosts($url)"
method_missing,class.jetpack-client-server.php,170,"Class static method \Jetpack::api_url($relative_url) is missing","\Jetpack::api_url($relative_url)"
method_missing,class.jetpack-debugger.php,88,"Class static method \Jetpack::fix_url_for_bad_hosts($url) is missing","\Jetpack::fix_url_for_bad_hosts($url)"

# VaultPress
method_missing,vaultpress.php,2999,"Class static method \Jetpack::load_xml_rpc_client() is missing","\Jetpack::load_xml_rpc_client()"
method_missing,vaultpress.php,3018,"Class static method \Jetpack::load_xml_rpc_client() is missing","\Jetpack::load_xml_rpc_client()"

$ Widget for EventBrite API
function_missing,frontend/class-frontend.php,65,"Function jetpack_photon_parse_url($url,$component=-1) is missing","jetpack_photon_parse_url($url,$component=-1)"

The migrate thing is weird though, I don't know where it came from. To sanity check these results here's what the difference to the latest Jetpack version:

method_missing,modules/comments.php,27,"Class static method \Jetpack::dns_prefetch($new_urls=\null) is missing","\Jetpack::dns_prefetch($new_urls=\null)"
method_missing,modules/likes.php,16,"Class static method \Jetpack::dns_prefetch($new_urls=\null) is missing","\Jetpack::dns_prefetch($new_urls=\null)"
method_missing,modules/masterbar/masterbar.php,116,"Class static method \Jetpack::dns_prefetch($new_urls=\null) is missing","\Jetpack::dns_prefetch($new_urls=\null)"
method_missing,modules/photon-cdn.php,17,"Class static method \Jetpack::dns_prefetch($new_urls=\null) is missing","\Jetpack::dns_prefetch($new_urls=\null)"
method_missing,modules/comment-likes.php,16,"Class static method \Jetpack::dns_prefetch($new_urls=\null) is missing","\Jetpack::dns_prefetch($new_urls=\null)"
method_missing,modules/shortcodes/videopress.php,13,"Class static method \Jetpack::dns_prefetch($new_urls=\null) is missing","\Jetpack::dns_prefetch($new_urls=\null)"
method_missing,modules/photon.php,15,"Class static method \Jetpack::dns_prefetch($new_urls=\null) is missing","\Jetpack::dns_prefetch($new_urls=\null)"
method_missing,class.jetpack-gutenberg.php,76,"Class static method \Jetpack_Gutenberg::register_plugin($slug) is missing","\Jetpack_Gutenberg::register_plugin($slug)"
method_missing,class.jetpack-gutenberg.php,94,"Class static method \Jetpack_Gutenberg::set_extension_unavailability_reason($slug,$reason) is missing","\Jetpack_Gutenberg::set_extension_unavailability_reason($slug,$reason)"

[jeherve]

Putting this on hold since we'll need to make changes to Akismet and VaultPress first.

[jeherve]

@kraftbj Sorry, one of the tests was failing, I had to bring the provider back. This will consequently need another review. Thank you!

[jeherve]

r233300-wpcom

[jeherve]

@kraftbj I had to update a package's version number. Could I ask for one last review? :)

Thank you!

[github-actions]

Great news! One last step: head over to your WordPress.com diff, D46167-code, and commit it.
Once you've done so, come back to this PR and add a comment with your changeset ID.

Thank you!