Skip to content

Lazy Images: Move into a package #16657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeherve merged 40 commits into from
Aug 24, 2020
Merged

Lazy Images: Move into a package #16657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
5839699
Migrate the Lazy Images module into a standalone package
davidlonjon Jul 31, 2020
746e75e
Fix an issue with a comma being in place of a semi column
davidlonjon Jul 31, 2020
a18605c
Fix a spelling mistake
davidlonjon Jul 31, 2020
d4618de
Fix coding standards
davidlonjon Jul 31, 2020
f0cc1b0
Fix coding standards
davidlonjon Jul 31, 2020
33ea52d
Fix spelling mistake
davidlonjon Jul 31, 2020
f467b76
Fix require path
davidlonjon Jul 31, 2020
5cf899f
Fix methods visibility
davidlonjon Jul 31, 2020
acddf4e
Remove irrelevant PHPDoc comment
davidlonjon Jul 31, 2020
07527ff
Setup tooling for linting and running unit tests
davidlonjon Jul 31, 2020
355d5e2
Update README
davidlonjon Jul 31, 2020
0df3db6
Move the build of the Lazy Images JavaScript assets to the core Jetpa…
davidlonjon Aug 4, 2020
ec5dbf8
Remove logic related to PHPCS checks
davidlonjon Aug 4, 2020
8ca53cf
Move the commands to run PHP unit tests into the composer.json file
davidlonjon Aug 4, 2020
1530be8
Update README
davidlonjon Aug 4, 2020
d48c196
Revert back the jetpack manifest file as it is auto generated
davidlonjon Aug 4, 2020
37bef2c
Add a missing composer install command
davidlonjon Aug 4, 2020
9b89229
Add missing @sign
davidlonjon Aug 4, 2020
df47e5a
Merge branch 'master' into add/jetpack-lazy-images-package
gravityrail Aug 5, 2020
63d8395
Refactor to allow running PHP unit tests on a CI environment as well …
davidlonjon Aug 6, 2020
cc0cf00
Merge branch 'add/jetpack-lazy-images-package' of github.com:Automatt…
davidlonjon Aug 6, 2020
82d6adc
Fix script name
davidlonjon Aug 6, 2020
9cb3665
Merge branch 'master' into add/jetpack-lazy-images-package
davidlonjon Aug 6, 2020
d2fa522
Formatting
gravityrail Aug 13, 2020
2603c45
Refactor to streamline the PHP unit tests with the other packages
davidlonjon Aug 14, 2020
4f0ff88
Fix instructions in README
davidlonjon Aug 14, 2020
18c6f99
Add some ignore rules for phpcs checks
davidlonjon Aug 14, 2020
045399f
Add repositories reference to streamline with other packages
davidlonjon Aug 14, 2020
5bfe7aa
Fix PHPCS warnings by adding PHPCS ignore comments and renaming files…
davidlonjon Aug 14, 2020
e169b52
Merge branch 'master' into add/jetpack-lazy-images-package
davidlonjon Aug 14, 2020
30c3a8a
Add the build-packages command to the build-production command
davidlonjon Aug 14, 2020
6f61269
Remove un-needed entries in .gitattributes
davidlonjon Aug 14, 2020
8f18dc1
test attachments attributes with wordbless (#16843)
leogermani Aug 17, 2020
0eb8384
Merge branch 'master' into add/jetpack-lazy-images-package
gravityrail Aug 17, 2020
cba84cf
Merge branch 'add/jetpack-lazy-images-package' of github.com:Automatt…
gravityrail Aug 17, 2020
5044142
Merge branch 'master' into add/jetpack-lazy-images-package
leogermani Aug 17, 2020
0dfe31d
Update composer.lock file
davidlonjon Aug 18, 2020
ca1ae14
Fix namespace path
davidlonjon Aug 18, 2020
96657cd
Refactor unit test to assert that the wp_get_attachment_image functio…
davidlonjon Aug 18, 2020
ff30622
Merge branch 'master' into add/jetpack-lazy-images-package
davidlonjon Aug 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .eslintignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,9 @@
/modules/custom-css/custom-css/js/core-customizer-css-preview.js
/modules/custom-css/custom-css/js/core-customizer-css.core-4.9.js
/modules/custom-css/custom-css/js/core-customizer-css.js
/modules/lazy-images/js/lazy-images.js
/packages/lazy-images/src/js/lazy-images.js
/packages/lazy-images/vendor

/modules/widgets/search/js/search-widget-admin.js
/vendor/

Expand Down
1 change: 1 addition & 0 deletions .phpcs.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,4 +47,5 @@

<exclude-pattern>/node_modules/*</exclude-pattern>
<exclude-pattern>/vendor/*</exclude-pattern>
<exclude-pattern>/packages/*/wordpress/*</exclude-pattern>
</ruleset>
3 changes: 2 additions & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
"automattic/jetpack-error": "@dev",
"automattic/jetpack-heartbeat": "@dev",
"automattic/jetpack-jitm": "@dev",
"automattic/jetpack-lazy-images": "@dev",
"automattic/jetpack-logo": "@dev",
"automattic/jetpack-options": "@dev",
"automattic/jetpack-partner": "@dev",
Expand All @@ -42,7 +43,7 @@
"wp-coding-standards/wpcs": "2.3.0"
},
"scripts": {
"php:compatibility": "vendor/bin/phpcs -p -s --runtime-set testVersion '5.6-' --standard=PHPCompatibilityWP --ignore=docker,tools,tests,node_modules,vendor --extensions=php",
"php:compatibility": "vendor/bin/phpcs -p -s --runtime-set testVersion '5.6-' --standard=PHPCompatibilityWP --ignore=docker,tools,tests,node_modules,vendor,packages/*/wordpress --extensions=php",
"php:lint": "vendor/bin/phpcs -p -s",
"php:changed": "vendor/sirbrillig/phpcs-changed/bin/phpcs-changed --git",
"php:autofix": "vendor/bin/phpcbf",
Expand Down
Loading