Use blog token to add new comment subscriber #16692
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leogermani
force-pushed
the
update/subscribe_comments_use_blog_token
branch
from
9a95366 to
ebcbc89
Compare
leogermani
force-pushed
the
add/xmlrpc-async-call-lib
branch
from
e6c2051 to
455225a
Compare
leogermani
force-pushed
the
update/subscribe_comments_use_blog_token
branch
from
ebcbc89 to
80093d7
Compare
leogermani
force-pushed
the
add/xmlrpc-async-call-lib
branch
from
56c669e to
8afe88b
Compare
leogermani
force-pushed
the
update/subscribe_comments_use_blog_token
branch
from
80093d7 to
ac48e50
Compare
10 tasks
leogermani
force-pushed
the
update/subscribe_comments_use_blog_token
branch
from
ac48e50 to
30ed6bf
Compare
leogermani
added
[Status] Needs Review
Collaborator
|
Thank you for the great PR description! When this PR is ready for review, please apply the E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-16692 Scheduled Jetpack release: September 1, 2020. |
kbrown9
approved these changes
Aug 11, 2020
Member
kbrown9
left a comment
kbrown9
left a comment
There was a problem hiding this comment.
I tested this using the provided testing instructions, and the subscriber was added to the comment, as expected.
kbrown9
added
[Status] Ready to Merge
matticbot
added
[Status] Needs Changelog
and removed
[Status] Ready to Merge
pereirinha
pushed a commit
that referenced
this pull request
Sep 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the token used to dispatch requests to subscribe to comments.
Changes proposed in this Pull Request:
Jetpack product discussion
p9dueE-1Dv-p2
Does this pull request change what data or activity we track or use?
No
Testing instructions:
Set up a connected Jetpack
Activate the Subscription module
Visit your site as an anonymous user
Leave a comment on a post, enter a valid email and check the "Notify me of follow-up comments by email" box.
verify the subscription worked. See 25ebc-pb/#plain
Proposed changelog entry for your changes: