Form Block: allowing marketing consent collection #16723

reintjanhoiting1 · 2020-08-05T11:24:32Z

Changes proposed in this Pull Request:

Lets expand the form block, add a new option allowing folks to collect marketing consent for their contact forms.

Jetpack product discussion
N/A

Does this pull request change what data or activity we track or use?

It adds 1 metadata field to the “feedback” post type.
Testing instructions:

test case 1

Go to Posts > Add New
Search for ‘form’.
Select any of the form types

test case 2

Perform test case 1.
Select the form block.
Click on add “add email permission request”.
Select the “Mention that you can email”
See the new implicit “consent” form element is added to your form.
Go to the preview, see the new implicit “consent” form element is added to your form.
/Todo WIP/
Fill in a form entry, select the consent.
Find the new entry on the feedback page.
/Todo WIP/

test case 3

Perform test case 1.
Select the form block.
Click on add “add email permission request”.
Select the “Add a privacy checkbox”
See the new explicit “consent” form element is added to your form.
Go to the preview, see the new implicit “consent” form element is added to your form.
/Todo WIP/
Fill in a form entry, select the consent.
Find the new entry on the feedback page.
/Todo WIP/

jetpackbot · 2020-08-05T11:33:29Z

	Warnings
⚠️	"Proposed changelog entry" is missing for this PR. Please include any meaningful changes

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-16723

Generated by 🚫 dangerJS against 3cb9b52

jeherve

Thanks for that PR!

I've left a few comments below. Do you think you could rebase that branch against master? It's a bit hard to review right now since it includes quite a few unrelated commits. I've rebased the feature branch just now.

extensions/blocks/contact-form/components/jetpack-newsletter-integration-settings.js

extensions/blocks/contact-form/edit.js

extensions/blocks/contact-form/components/jetpack-field-consent.js

* add async call class to connection package * add docs to the new class * Async XMLRPC Requests: Simplifying the code. Combining the `multisite` and `single-site` functions into one to improve readability. Co-authored-by: Sergey Mitroshin <[email protected]>

* Adds support for saving the content of a donations block into the post content, so the published view contains the block output. * It also follows up Automattic#16593 (comment) and implements the content sync logic as suggested there.

Automattic#16724) * Add basic scaffold for premium nudge * Add documentation to code. * Remove testing check and use check for avaiabiliity * Update extensions/blocks/social-previews/editor.js Co-authored-by: Damián Suárez <[email protected]> * Update extensions/blocks/social-previews/editor.js Co-authored-by: Damián Suárez <[email protected]> * Remove testing comment * Normalize to a single button and onClick action Co-authored-by: Damián Suárez <[email protected]>

…c#16736) Methods `is_active()`, `activate_monitor()`, and `deactivate_monitor()` have not been used since Jetpack 4.2. Marking them as deprecated now. The WP.com endpoint `jetpack.monitor.getLastDowntime` is not tied to any particular user, so using `blog_token` is sufficient. Replacing the `user_token` with `blog_token` for that API request.

…16758) The API request `jetpack.protect.requestKey` does not use the user ID, and can be authenticated using `blog_token`.

Co-authored-by: Renovate Bot <[email protected]>

Add travis job url into slack messages

* Add retry to .org login method * cleanup

…6743)

reintjanhoiting1 · 2020-08-10T11:24:57Z

Added support for the Newsletter variation and consent field

reintjanhoiting1

Updated the pull request, made the code a lot cleaner.
@jeherve are you able to rebase the feature branch from master for us?

extensions/blocks/contact-form/components/jetpack-field-consent.js

Co-authored-by: Renovate Bot <[email protected]>

add translatable strings add isSimpleSite check

jeherve · 2020-08-11T16:06:26Z

closing this in favor of #16808; it should make it easier to review things.

matticbot added the Touches WP.com Files label Aug 5, 2020

jeherve added [Status] In Progress [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Contact Form [Pri] Normal labels Aug 5, 2020

jeherve requested changes Aug 5, 2020

View reviewed changes

jeherve added [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. and removed [Status] In Progress labels Aug 5, 2020

leogermani and others added 2 commits August 5, 2020 14:05

Lodash: Revert to previous version (Automattic#16735)

c07b42b

reintjanhoiting1 force-pushed the add/form-email-marketing-consent branch from 7647030 to a64f5e0 Compare August 6, 2020 07:06

mmtr and others added 2 commits August 6, 2020 10:35

Donations: Save block content (Automattic#16705)

e3860aa

* Adds support for saving the content of a donations block into the post content, so the published view contains the block output. * It also follows up Automattic#16593 (comment) and implements the content sync logic as suggested there.

reintjanhoiting1 force-pushed the add/form-email-marketing-consent branch from f14f5c9 to f9e3d56 Compare August 7, 2020 11:29

sergeymitr and others added 3 commits August 7, 2020 12:25

Jetpack Protect: Replace user_token with blog_token. (Automattic#…

b96e08f

…16758) The API request `jetpack.protect.requestKey` does not use the user ID, and can be authenticated using `blog_token`.

adds tracking for deleted but active master users (Automattic#16750)

12f82ed

reintjanhoiting1 force-pushed the add/form-email-marketing-consent branch from f9e3d56 to 8eec5b4 Compare August 10, 2020 07:08

rilwis and others added 9 commits August 10, 2020 10:27

Add Slim SEO to list of SEO plugins (Automattic#16778)

10d037a

Donations: Remove feature from Personal plans (Automattic#16742)

c2ea60d

avoid warning on wp cli (Automattic#16760)

917261a

Update jest monorepo to v26 (Automattic#16774)

abc6741

Co-authored-by: Renovate Bot <[email protected]>

Update dependency url-loader to v4 (Automattic#16772)

ae5f858

Co-authored-by: Renovate Bot <[email protected]>

CC me only on master failures; (Automattic#16780)

60fbb28

Add travis job url into slack messages

E2E test job will fail CI builds from now (Automattic#16757)

b4e342d

E2E tests: Add retry to .org login method (Automattic#16756)

b0348d5

* Add retry to .org login method * cleanup

Donations: Avoid using buttons elements in block output (Automattic#1…

3204915

…6743)

reintjanhoiting1 force-pushed the add/form-email-marketing-consent branch from 5014082 to d2ae31b Compare August 10, 2020 11:23

reintjanhoiting1 marked this pull request as ready for review August 10, 2020 11:25

reintjanhoiting1 requested a review from georgestephanis as a code owner August 10, 2020 11:25

reintjanhoiting1 commented Aug 10, 2020

View reviewed changes

extensions/blocks/contact-form/components/jetpack-field-consent.js Outdated Show resolved Hide resolved

renovate bot and others added 7 commits August 10, 2020 14:49

Update dependency css-loader to v4 (Automattic#16771)

f0ce304

Co-authored-by: Renovate Bot <[email protected]>

Update dependency sass-loader to v9.0.3 (Automattic#16769)

e711bda

Co-authored-by: Renovate Bot <[email protected]>

add email marketing consent field

f75e498

remove the conditional text

1ebef75

add translatable strings add isSimpleSite check

add the consent field to the contact from in preview and live.

c170c7c

Add default values

2f6808e

Add news letter variation

3cb9b52

reintjanhoiting1 force-pushed the add/form-email-marketing-consent branch from d2ae31b to 3cb9b52 Compare August 10, 2020 13:01

jeherve added [Status] Needs Review This PR is ready for review. and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Aug 11, 2020

jeherve added this to the 8.9 milestone Aug 11, 2020

jeherve assigned jeherve and reintjanhoiting1 Aug 11, 2020

jeherve mentioned this pull request Aug 11, 2020

Form Block: add a new Consent Field, a new Newsletter setting, and a new newsletter variation #16808

Merged

3 tasks

jeherve closed this Aug 11, 2020

kraftbj removed the [Status] Needs Review This PR is ready for review. label Sep 29, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Form Block: allowing marketing consent collection #16723

Form Block: allowing marketing consent collection #16723

Uh oh!

reintjanhoiting1 commented Aug 5, 2020

Uh oh!

jetpackbot commented Aug 5, 2020 •

edited

Loading

Uh oh!

jeherve left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

reintjanhoiting1 commented Aug 10, 2020

Uh oh!

reintjanhoiting1 left a comment

Uh oh!

Uh oh!

jeherve commented Aug 11, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

Form Block: allowing marketing consent collection #16723

Form Block: allowing marketing consent collection #16723

Uh oh!

Conversation

reintjanhoiting1 commented Aug 5, 2020

test case 1

test case 2

test case 3

Uh oh!

jetpackbot commented Aug 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jeherve left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

reintjanhoiting1 commented Aug 10, 2020

Uh oh!

reintjanhoiting1 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jeherve commented Aug 11, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

jetpackbot commented Aug 5, 2020 •

edited

Loading