Packages: Update filenames after #16810 #16838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraftbj
added
[Type] Bug
![test-case-reminder[bot]](https://avatars.githubusercontent.com/u/1306301?s=60&v=4){kind=small}
There was a problem hiding this comment.
Here are some suggested test cases for this PR.
Connection
- In-place connection with free plan
- In-place connection with paid plan
- In-place connection with product purchase
- Classic connection. Use Safari, or set a constant
JETPACK_SHOULD_NOT_USE_CONNECTION_IFRAMEto true - Disconnect/reconnect connection
- Secondary user connection
- Connection on multisite
If you think that suggestions should be improved please edit the configuration file here. You can also modify/add test-suites to be used in the configuration file.
Collaborator
|
Thank you for the great PR description! When this PR is ready for review, please apply the E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-16838 Scheduled Jetpack release: September 1, 2020. |
jeherve
approved these changes
Aug 14, 2020
jeherve
added
[Status] Ready to Merge
matticbot
added
[Status] Needs Changelog
[Status] Needs Package Release
pereirinha
pushed a commit
that referenced
this pull request
Sep 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our testing now uses
phpunit.xml.distwhich was not updated in package's.gitattributesfiles.Fixes issue introduced in #16810
Changes proposed in this Pull Request:
Jetpack product discussion
n/a
Does this pull request change what data or activity we track or use?
n/a
Testing instructions:
composer install --no-devon a project with one of these packages and not seephpunit.xml.distin the distributed copy.Proposed changelog entry for your changes: