Skip to content

Conversation

@reintjanhoiting1
Copy link
Contributor

See #16808.
Fixes #17027.

Changes proposed in this Pull Request:

support subdirectory for wordpress

Does this pull request change what data or activity we track or use?

No

Testing instructions:

test case 1

  • Go to Posts > Add New
  • Search for ‘Newsletter Sign-up’.
  • Select the form block in the Gutenberg editor.
  • collapse the "Newsletter Integration" on the right side
    image
  • Click install plugin
    image
  • click open creative mail, this should open the creative mail plugin in a new tab.

@jetpackbot
Copy link
Collaborator

Warnings
⚠️

The PR is missing at least one [Status] label. Suggestions: [Status] In Progress, [Status] Needs Review

⚠️ "Proposed changelog entry" is missing for this PR. Please include any meaningful changes

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-17029

Generated by 🚫 dangerJS against 2134cb2

@jeherve jeherve added [Status] Needs Cherry-Pick [Type] Bug When a feature is broken and / or not performing as intended [Feature] Contact Form labels Aug 31, 2020
@jeherve jeherve added this to the 8.9 milestone Aug 31, 2020
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Merging.

@jeherve jeherve merged commit a43fcbc into master Aug 31, 2020
@jeherve jeherve deleted the update/newsletter-intergration-subdirectory-support branch August 31, 2020 16:21
jeherve pushed a commit that referenced this pull request Aug 31, 2020
@jeherve
Copy link
Member

jeherve commented Aug 31, 2020

Cherry-picked to branch-8.9 in 7ed3798

@jeherve
Copy link
Member

jeherve commented Sep 1, 2020

Internal reference: r212966-wpcom

pereirinha pushed a commit that referenced this pull request Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Contact Form Touches WP.com Files [Type] Bug When a feature is broken and / or not performing as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Newsletter Integration: link to plugin settings does not take subdir installations into account

6 participants