-
Notifications
You must be signed in to change notification settings - Fork 846
E2E Tests: Migrate to github actions #17094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Scheduled Jetpack release: November 10, 2020. E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-17094 Thank you for the great PR description! When this PR is ready for review, please apply the |
jeherve
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests seem to pass.
I was a bit worried about potentially having secrets slip out in the builds, but couldn't find anything bad.
I only have 2 questions below.
ad8277c to
c44d35d
Compare
|
I really dig the approach here. The action is erroring, though, I think it'll give us a lot of future flexibility, so I'm good to roll through it once it passes. |
91c2f8a to
ac39b2d
Compare
|
Hi @brbrr 👋🏻 We're currently working to better understand what would it take to have E2E tests in other repos use a specific/latest version of Gutenberg*. @ockham pointed me to the work you've done here, and also mentioned this PR as we also want to understand what (mostly E2E) tooling/infrastructure is available for each project, and Jetpack seems to have have the edge for now as a template/inspiration we could use for other projects. We also would like to wait for this PR to be merged before adding any new tests (as part of this other related task). That being said, how can we help you testing this PR? I see the testing instructions just mention checking if all tests pass in the list of GH jobs below, as some are failing. Is there anything we can do to help you? Thanks! 🙇🏻 *See pc9Uba-8b-p2 |
kraftbj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Added a minor commit to remove the allowed-failure in travis for the e2e-guten test.
|
Hey @fullofcaffeine! Sorry for the late response. The PR is merged, so nothing to test here :) There is this PR in the works (it is ready for review, but I still want to double-check it if works fine) #17523 It is infrastructure related, but with that PR merged, we would be able to run multiple E2E containers in parallel. I would appreciate a review :) |
Move E2E tests from Travis into GH actions
With GH Actions, we could customize our runs, run different suites on different events (e.g. on new tags, merges to master, etc)
Jetpack product discussion
n/a
Does this pull request change what data or activity we track or use?
n/a
Testing instructions:
Proposed changelog entry for your changes: