Skip to content

Conversation

@brbrr
Copy link
Contributor

@brbrr brbrr commented Sep 7, 2020

Move E2E tests from Travis into GH actions

With GH Actions, we could customize our runs, run different suites on different events (e.g. on new tags, merges to master, etc)

Jetpack product discussion

n/a

Does this pull request change what data or activity we track or use?

n/a

Testing instructions:

  • Take a look at "Checks" section
  • Make sure the tests have passed.

Proposed changelog entry for your changes:

  • n/a

@brbrr brbrr self-assigned this Sep 7, 2020
@brbrr brbrr changed the title Add github e2e workflow file E2E Tests: Migrate to github actions Sep 7, 2020
@jetpackbot
Copy link
Collaborator

jetpackbot commented Sep 7, 2020

Scheduled Jetpack release: November 10, 2020.
Scheduled code freeze: November 3, 2020

E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-17094

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Generated by 🚫 dangerJS against ba31235

@brbrr brbrr added [Status] Needs Review This PR is ready for review. and removed [Status] In Progress labels Sep 10, 2020
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests seem to pass.

I was a bit worried about potentially having secrets slip out in the builds, but couldn't find anything bad.

I only have 2 questions below.

@jeherve jeherve added [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. and removed [Status] Needs Review This PR is ready for review. labels Sep 17, 2020
@brbrr brbrr force-pushed the update/e2e-use-github-actions branch from ad8277c to c44d35d Compare September 25, 2020 10:32
@brbrr brbrr added [Status] Needs Review This PR is ready for review. and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Oct 6, 2020
@kraftbj
Copy link
Contributor

kraftbj commented Oct 16, 2020

I really dig the approach here. The action is erroring, though, ERROR: WP_SITE_URL is not set after launching an ngrok.

I think it'll give us a lot of future flexibility, so I'm good to roll through it once it passes.

@kraftbj kraftbj added [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. [Type] Janitorial and removed [Status] Needs Review This PR is ready for review. labels Oct 16, 2020
@jeherve jeherve added the Actions GitHub actions used to automate some of the work around releases and repository management label Oct 20, 2020
@brbrr brbrr added [Status] Needs Review This PR is ready for review. and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Oct 23, 2020
@brbrr brbrr force-pushed the update/e2e-use-github-actions branch from 91c2f8a to ac39b2d Compare October 26, 2020 12:49
@fullofcaffeine
Copy link
Contributor

fullofcaffeine commented Oct 26, 2020

Hi @brbrr 👋🏻

We're currently working to better understand what would it take to have E2E tests in other repos use a specific/latest version of Gutenberg*. @ockham pointed me to the work you've done here, and also mentioned this PR as we also want to understand what (mostly E2E) tooling/infrastructure is available for each project, and Jetpack seems to have have the edge for now as a template/inspiration we could use for other projects.

We also would like to wait for this PR to be merged before adding any new tests (as part of this other related task).

That being said, how can we help you testing this PR? I see the testing instructions just mention checking if all tests pass in the list of GH jobs below, as some are failing. Is there anything we can do to help you?

Thanks! 🙇🏻


*See pc9Uba-8b-p2

Copy link
Contributor

@kraftbj kraftbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Added a minor commit to remove the allowed-failure in travis for the e2e-guten test.

@kraftbj kraftbj added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Oct 26, 2020
@kraftbj kraftbj merged commit c572e39 into master Oct 26, 2020
@kraftbj kraftbj deleted the update/e2e-use-github-actions branch October 26, 2020 20:34
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Oct 26, 2020
@github-actions github-actions bot added this to the 9.1 milestone Oct 26, 2020
@brbrr
Copy link
Contributor Author

brbrr commented Oct 28, 2020

Hey @fullofcaffeine! Sorry for the late response.

The PR is merged, so nothing to test here :) There is this PR in the works (it is ready for review, but I still want to double-check it if works fine) #17523

It is infrastructure related, but with that PR merged, we would be able to run multiple E2E containers in parallel. I would appreciate a review :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Actions GitHub actions used to automate some of the work around releases and repository management E2E Tests [Type] Janitorial

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants