Skip to content

Paid Blocks: change filter to add upgrade banner #17583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
retrofox merged 2 commits into from
Oct 26, 2020
Merged

Paid Blocks: change filter to add upgrade banner #17583

retrofox merged 2 commits into from
Oct 26, 2020

Conversation

@retrofox
Copy link
Contributor

@retrofox retrofox commented Oct 22, 2020

It changes the filter used to add the banner to the paid blocks, replacing it with editor.BlockEdit. It will allow moving the banner at the top in the block settings sidebar, once the core PR ships WordPress/gutenberg#23993.

Fixes #

Changes proposed in this Pull Request:

  • Replace filter to add the upgrade banner

Jetpack product discussion

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Appy these changes. Nothing should change for now, unless Core: Adding block styles via editor.BlockEdit filter WordPress/gutenberg#23993 ships
  • Test with a free plan
  • Add a paid block. Use the premium work in the blocks insert
  • Confirm whole upgrade stuff work as expected: you should see the banner only when the paid block is selected, also confirm you see the banner in the sidebar, confirm the banner shows in core/cover only when you try to upload a video, etc

Proposed changelog entry for your changes:

  • Replace filter to add the upgrade banner

@retrofox
paid-blocks: change filter to add upgrade banner
25baf3e 
It changes the filter to add the banner to the paid blocks, replacing it with editor.BlockEdit. It will allow move the banner at the top im the lbock settings sidebar, one the core PR ships WordPress/gutenberg#23993
@matticbot
Copy link
Contributor

matticbot commented Oct 22, 2020

Caution: This PR has changes that must be merged to WordPress.com
Hello retrofox! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D51668-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@retrofox retrofox requested a review from a team October 22, 2020 15:35
@retrofox retrofox added [Extension] Paid Blocks Functionality used to handle notices for paid blocks [Status] Needs Team Review Obsolete. Use Needs Review instead. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it labels Oct 22, 2020
@retrofox retrofox self-assigned this Oct 22, 2020
@jetpackbot
Copy link
Collaborator

jetpackbot commented Oct 22, 2020 •
edited
Loading

Scheduled Jetpack release: November 10, 2020.
Scheduled code freeze: November 3, 2020

E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-17583

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Generated by 🚫 dangerJS against edfcefc

allilevine
allilevine approved these changes Oct 26, 2020
View reviewed changes
Copy link
Member

@allilevine allilevine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested these changes applied to a simple site with a free plan, and the premium block banner displayed correctly.

Calendly block with premium banner:
Screen Shot 2020-10-26 at 11 42 03 AM

Clicked out of Calendly block and the banner disappears:
Screen Shot 2020-10-26 at 11 42 10 AM

I can't upload to the Video premium block, but I can insert a video link:
Screen Shot 2020-10-26 at 11 45 09 AM

@retrofox retrofox added [Status] Needs Review This PR is ready for review. and removed [Status] Needs Team Review Obsolete. Use Needs Review instead. labels Oct 26, 2020
@retrofox retrofox requested a review from a team October 26, 2020 16:14
@jeherve jeherve added this to the 9.1 milestone Oct 26, 2020
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Oct 26, 2020
jeherve
jeherve approved these changes Oct 26, 2020
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well for me. 🚢

@retrofox
Copy link
Contributor Author

retrofox commented Oct 26, 2020

r215865-wpcom

@retrofox retrofox merged commit 7b01b19 into master Oct 26, 2020
@retrofox retrofox deleted the update/paid-block-replace-filter-to-add-upgrade-banner branch October 26, 2020 21:26
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeherve jeherve jeherve approved these changes

@allilevine allilevine allilevine approved these changes

Assignees

@retrofox retrofox

Labels

[Extension] Paid Blocks Functionality used to handle notices for paid blocks Touches WP.com Files [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Projects

None yet

Milestone

9.1

Development

Successfully merging this pull request may close these issues.

6 participants

@retrofox @matticbot @jetpackbot @jeherve @allilevine