Updated PHPCS: Packages and Debugger

[kraftbj]

After #17406, updated the "requiredlist" files to match new PHPCS rules for packages and the debugger.

Changes proposed in this Pull Request:

• PHPCS

Jetpack product discussion

n/a

Does this pull request change what data or activity we track or use?

n/a

Testing instructions:

n/a

Proposed changelog entry for your changes:

• n/a

[test-case-reminder]

Here are some suggested test cases for this PR.

Connection

• In-place connection with free plan
• In-place connection with paid plan
• In-place connection with product purchase
• Classic connection. Use Safari, or set a constant JETPACK_SHOULD_NOT_USE_CONNECTION_IFRAME to true
• Disconnect/reconnect connection
• Secondary user connection
• Connection on multisite

Verify that the changes are compatible with the plugins that use the connection package.

• WooCommerce Payments
• Jetpack Boost
• Previous versions of Jetpack

If you think that suggestions should be improved please edit the configuration file here. You can also modify/add test-suites to be used in the configuration file.

[kraftbj]

After 9.1 branches off and #17406 merges, we need to update base branch to master, then this can be merged.

[anomiex]

After 9.1 branches off and #17406 merges, we need to update base branch to master, then this can be merged.

Once #17406 merges and its branch is deleted, Github will automatically set the base branch to master (or whatever we're calling it by then).

[anomiex]

Changes look sane to me. None of the comments I left are anything I'd hold up approval on.

[anomiex]

Could just remove the unused variables here, if you want.

I wouldn't recommend that for actual methods intended for being passed as callbacks, but this is just a closure.

[anomiex]

Random thought: Maybe we should have a sniff to prefer assertCount over things like this.

[anomiex]

We could drop the (bool) entirely, PHP implicitly casts to bool in this situation anyway.

The base branch was changed.

[anomiex]

Ugh, Github. It did change the branch to master, but still thinks it wants to apply all the patches from #17406 as part of this patch. Currently when this gets squash-and-merged those will wind up going away, but I have to wonder what would happen if some other patch touching those files got merged in the mean time.

[jetpackbot]

Scheduled Jetpack release: November 10, 2020.
Scheduled code freeze: November 3, 2020

E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-17617

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Generated by 🚫 dangerJS against 939cae1