Skip to content

Conversation

@kraftbj
Copy link
Contributor

@kraftbj kraftbj commented Oct 26, 2020

After #17406, updated the "requiredlist" files to match new PHPCS rules for packages and the debugger.

Changes proposed in this Pull Request:

  • PHPCS

Jetpack product discussion

n/a

Does this pull request change what data or activity we track or use?

n/a

Testing instructions:

n/a

Proposed changelog entry for your changes:

  • n/a

@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello kraftbj! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D51817-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@kraftbj
Copy link
Contributor Author

kraftbj commented Oct 26, 2020

After 9.1 branches off and #17406 merges, we need to update base branch to master, then this can be merged.

@anomiex
Copy link
Contributor

anomiex commented Oct 27, 2020

After 9.1 branches off and #17406 merges, we need to update base branch to master, then this can be merged.

Once #17406 merges and its branch is deleted, Github will automatically set the base branch to master (or whatever we're calling it by then).

anomiex
anomiex previously approved these changes Oct 27, 2020
Copy link
Contributor

@anomiex anomiex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me.

@anomiex anomiex removed the [Status] Needs Review This PR is ready for review. label Oct 27, 2020
Base automatically changed from add/phpcs-rules-from-MediaWiki to master October 27, 2020 20:32
@kraftbj kraftbj dismissed anomiex’s stale review October 27, 2020 20:32

The base branch was changed.

@github-actions github-actions bot added the [Status] Needs Package Release This PR made changes to a package. Let's update that package now. label Oct 27, 2020
@kraftbj kraftbj added [Status] Needs Review This PR is ready for review. and removed [Status] Blocked / Hold labels Oct 27, 2020
anomiex
anomiex previously approved these changes Oct 28, 2020
@anomiex anomiex added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Oct 28, 2020
@jetpackbot
Copy link
Collaborator

Scheduled Jetpack release: November 10, 2020.
Scheduled code freeze: November 3, 2020

E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-17618

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Generated by 🚫 dangerJS against b7e5b97

@kraftbj kraftbj merged commit 17fa9df into master Oct 28, 2020
@kraftbj kraftbj deleted the phpcs/pr-2 branch October 28, 2020 18:58
@matticbot matticbot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Oct 28, 2020
@kraftbj
Copy link
Contributor Author

kraftbj commented Oct 28, 2020

r216014-wpcom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AMP [Status] Needs Package Release This PR made changes to a package. Let's update that package now. Touches WP.com Files [Type] Janitorial Unit Tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants