-
Notifications
You must be signed in to change notification settings - Fork 846
Updated PHPCS: AMP, Tests, etc #17618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Caution: This PR has changes that must be merged to WordPress.com |
|
After 9.1 branches off and #17406 merges, we need to update base branch to |
anomiex
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sane to me.
|
Scheduled Jetpack release: November 10, 2020. E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-17618 Thank you for the great PR description! When this PR is ready for review, please apply the |
|
r216014-wpcom |
After #17406, updated the "requiredlist" files to match new PHPCS rules for packages and the debugger.
Changes proposed in this Pull Request:
Jetpack product discussion
n/a
Does this pull request change what data or activity we track or use?
n/a
Testing instructions:
n/a
Proposed changelog entry for your changes: