Skip to content

Updated PHPCS: Modules, endpoints, and general files #17619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kraftbj merged 2 commits into from
Oct 28, 2020
Merged

Updated PHPCS: Modules, endpoints, and general files #17619

kraftbj merged 2 commits into from
Oct 28, 2020

Conversation

@kraftbj
Copy link
Contributor

@kraftbj kraftbj commented Oct 26, 2020

After #17406, updated the "requiredlist" files to match new PHPCS rules for packages and the debugger.

Changes proposed in this Pull Request:

  • PHPCS

Jetpack product discussion

n/a

Does this pull request change what data or activity we track or use?

n/a

Testing instructions:

n/a

Proposed changelog entry for your changes:

  • n/a

@kraftbj kraftbj added this to the 9.2 milestone Oct 26, 2020
@kraftbj kraftbj requested a review from a team as a code owner October 26, 2020 21:47
@kraftbj kraftbj self-assigned this Oct 26, 2020
test-case-reminder[bot]
test-case-reminder bot reviewed Oct 26, 2020
View reviewed changes
Copy link

@test-case-reminder test-case-reminder bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some suggested test cases for this PR.

Publicize

  • Publish a post with Twitter integration
  • Publish a post with Facebook integration
  • Publish a post to all integrations at once

If you think that suggestions should be improved please edit the configuration file here. You can also modify/add test-suites to be used in the configuration file.

@kraftbj
Copy link
Contributor Author

kraftbj commented Oct 26, 2020

After 9.1 branches off and #17406 merges, we need to update base branch to master, then this can be merged.

@matticbot
Copy link
Contributor

matticbot commented Oct 26, 2020

Caution: This PR has changes that must be merged to WordPress.com
Hello kraftbj! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D51819-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@anomiex
Copy link
Contributor

anomiex commented Oct 27, 2020

After 9.1 branches off and #17406 merges, we need to update base branch to master, then this can be merged.

Once #17406 merges and its branch is deleted, Github will automatically set the base branch to master (or whatever we're calling it by then).

anomiex
anomiex previously approved these changes Oct 27, 2020
View reviewed changes
Copy link
Contributor

@anomiex anomiex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me.

Of the files in this patch currently listed by Fusion as not being in sync and where we're removing use statements,

  • _inc/lib/core-api/wpcom-endpoints/class-wpcom-rest-api-v2-endpoint-tweetstorm-gather.php reports no diff.
  • modules/search/class-jetpack-instant-search.php shows no uses of those uses in the diff.
  • modules/shortcodes/instagram.php reports no diff.

@anomiex anomiex removed the [Status] Needs Review This PR is ready for review. label Oct 27, 2020
Base automatically changed from add/phpcs-rules-from-MediaWiki to master October 27, 2020 20:32
@kraftbj kraftbj dismissed anomiex’s stale review October 27, 2020 20:32

The base branch was changed.

@kraftbj kraftbj added [Status] Needs Review This PR is ready for review. and removed [Status] Blocked / Hold labels Oct 27, 2020
anomiex
anomiex requested changes Oct 28, 2020
View reviewed changes
Copy link
Contributor

@anomiex anomiex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a manual rebase after #17595. Otherwise should be good.

@anomiex anomiex added [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. and removed [Status] Needs Review This PR is ready for review. labels Oct 28, 2020
anomiex
anomiex approved these changes Oct 28, 2020
View reviewed changes
modules/wpcom-block-editor/class-jetpack-wpcom-block-editor.php
require_once __DIR__ . '/functions.editor-type.php';
add_action( 'edit_form_top', 'Jetpack\EditorType\remember_classic_editor' );
add_filter( 'block_editor_settings', 'Jetpack\EditorType\remember_block_editor', 10, 2 );

Copy link
Contributor

@anomiex anomiex Oct 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lost a newline here in the rebase. Probably doesn't matter.

@anomiex anomiex added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Oct 28, 2020
@jetpackbot
Copy link
Collaborator

jetpackbot commented Oct 28, 2020

Scheduled Jetpack release: November 10, 2020.
Scheduled code freeze: November 3, 2020

E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-17619

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Generated by 🚫 dangerJS against f50bce5

@kraftbj kraftbj merged commit 8ab0362 into master Oct 28, 2020
@kraftbj kraftbj deleted the phpcs/pr-3 branch October 28, 2020 18:55
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Oct 28, 2020
@kraftbj
Copy link
Contributor Author

kraftbj commented Oct 28, 2020

r216013-wpcom

@kraftbj kraftbj mentioned this pull request Nov 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anomiex anomiex anomiex approved these changes

@sergeymitr sergeymitr sergeymitr approved these changes

+1 more reviewer

@test-case-reminder test-case-reminder[bot] test-case-reminder[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@kraftbj kraftbj

Labels

Touches WP.com Files [Type] Janitorial

Projects

None yet

Milestone

9.2

Development

Successfully merging this pull request may close these issues.

7 participants

@kraftbj @matticbot @anomiex @jetpackbot @sergeymitr @jeherve