Skip to content

Conversation

@scruffian
Copy link
Member

This line of CSS was introduced in #14493 for compatibility with the Zerif lite theme. This theme is no longer available on .org, but this line seems to cause a strange display issue in Twenty Twenty One:

Fixes #17552

If we remove this line everything still seems fine in all the other themes I have tested.

Changes proposed in this Pull Request:

  • Remove unnecessary CSS

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Activate TT1 theme
  • Activate the instant search Jetpack feature under performance (you'll need to purchase it)
  • Do a search
  • Check that the checkboxes look ok:

Screenshot 2020-12-03 at 11 42 54

Proposed changelog entry for your changes:

  • Fix display of checkboxes in Instant Search

@scruffian scruffian requested a review from bluefuton December 3, 2020 11:43
@scruffian scruffian requested a review from a team as a code owner December 3, 2020 11:43
@scruffian scruffian self-assigned this Dec 3, 2020
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello scruffian! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D53696-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@jetpackbot
Copy link
Collaborator

Warnings
⚠️

The PR is missing at least one [Status] label. Suggestions: [Status] In Progress, [Status] Needs Review

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against cf061e4

@scruffian scruffian added the [Status] Needs Review This PR is ready for review. label Dec 3, 2020
@jeherve jeherve added Instant Search [Feature] Search For all things related to Search [Type] Bug When a feature is broken and / or not performing as intended labels Dec 3, 2020
@jeherve jeherve added this to the 9.2.1 milestone Dec 3, 2020
@jeherve jeherve added [Status] Needs Cherry-Pick [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Dec 3, 2020
jeherve added a commit that referenced this pull request Dec 3, 2020
@jeherve jeherve merged commit f069185 into master Dec 3, 2020
@jeherve jeherve deleted the fix/instant-search-checkboxes branch December 3, 2020 12:39
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Dec 3, 2020
jeherve pushed a commit that referenced this pull request Dec 3, 2020
@jeherve
Copy link
Member

jeherve commented Dec 3, 2020

Cherry-picked to branch-9.2 in 6cf29d3

@jeherve
Copy link
Member

jeherve commented Dec 3, 2020

r217739-wpcom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Search For all things related to Search Touches WP.com Files [Type] Bug When a feature is broken and / or not performing as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Instant Search: checkboxes don't appear in Twenty Twenty One theme (WordPress 5.6 nightly)

5 participants