Sync: Use the Heartbeat package to generate the stats array

[kbrown9]

Changes proposed in this Pull Request:

The Sync package currently calls Jetpack::get_stat_data() to obtain the heartbeat stats array. The Sync package needs to be independent of Jetpack, so use the Heartbeat::generate_stats_array() method instead. When the Jetpack plugin is installed, this method returns the same data as Jetpack::get_stat_data().

I also fixed some phpcs warnings in test_class.jetpack-sync-modules-stats.php.

Jetpack product discussion

• n/a

Does this pull request change what data or activity we track or use?

• no

Testing instructions:

1. Install, activate, and connect Jetpack.

2. Set up your sandbox and Unagi so you can watch sync actions. For more info: PCYsg-lgg-p2

3. SSH in to your remote site and clear the last_heartbeat Jetpack option using wp cli:

   wp jetpack options delete last_heartbeat

4. Trigger the heartbeat cron job using wp cli:

   wp cron event run jetpack_v2_heartbeat

5. You should see the jetpack_sync_heartbeat_stats sync action in Unagi. Expand the meta data and verify that the data includes an array with these elements (version, wp-version, php-version, etc.).

Proposed changelog entry for your changes:

• n/a. I don't think these changes need a changelog entry.

[jetpackbot]

Scheduled Jetpack release: February 16, 2021.
Scheduled code freeze: February 8, 2021

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Generated by 🚫 dangerJS against 84a483c

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ All commits were linted before commit.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Include a changelog entry for any meaningful change.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

If you are an automattician, once your PR is ready for review add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.undefined

---

jetpack plugin:

• Next scheduled release: March 2, 2021.
• Scheduled code freeze: February 22, 2021