Disabled editing and deleting capabilities in WP-Admin Post list for Posts Page

[BogdanUngureanu]

Disables editing and deleting capabilities in WP-Admin Post list for the page that is configured as a Posts Page in WP-Admin.

Fixes Automattic/wp-calypso#52692

Changes proposed in this Pull Request:

• Removed the edit_post and delete_post capabilities for all users for the page is configured as a Posts page in WP-Admin.
• Added an info icon for informing the user why the page cannot be edited or deleted.

Does this pull request change what data or activity we track or use?

No

Testing instructions:

Atomic:

• Install Jetpack Beta plugin and switch to the current branch.
• Make sure that you have a Posts Page configured for your site (Configurable in Settings > Reading section).
• Go to WP-Admin > Pages section
• Make sure that the page configured in the second step cannot be edited and deleted
• Make sure that the page has an info icon with a title informing why the page cannot be edited or deleted.

Simple Sites

• Apply the following patch on your sandbox: D61647-code
• Copy projects/plugins/jetpack/modules/masterbar/wp-posts-list/class-posts-list-page-notification.php class into the corresponding WPCOM directory.
• Make sure that you have the Show wp-admin pages if available toggle on in wordpress.com/me/account section
• Go to your-site.wordpress.com/wp-admin/
• Make sure that you have a Posts Page configured for your site (Configurable in Settings > Reading section)
• Go to WP-Admin > Pages section
• Make sure that the page configured in the third step cannot be edited and deleted
• Make sure that the page has a info icon with a title informing why the page cannot be edited or deleted

Note: Since the implementation was added within a new directory (wp-posts-list) that it's not currently managed by Jetpack Fusion, the following diff also have to be reviewed: D61647-code.

[matticbot]

Caution: This PR has changes that must be merged to WordPress.com
Hello BogdanUngureanu! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D61647-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ⚠️ All commits were linted before commit.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

---

Jetpack plugin:

• Next scheduled release: June 1, 2021.
• Scheduled code freeze: May 24, 2021.

[tjcafferkey]

Make sure that the page has an info icon with a title informing why the page cannot be edited or deleted.

Is hovering over this supposed to reveal a tooltip with the title value? If so I'm unable to replicate this on both Atomic or Simple site.

[BogdanUngureanu]

Is hovering over this supposed to reveal a tooltip with the title value? If so I'm unable to replicate this on both Atomic or Simple site.

Yes, hovering over the icon should display a message about why the page cannot be edited. It's not actually a tooltip, it uses the built in HTML title attribute. Not ideal, but I couldn't find a library from WPCore to use instead.

[cpapazoglou]

Excellent work @BogdanUngureanu ! The code changes test well for me both in Simple & Atomic sites 🎉!

I have left some comments for discussion.

[mmtr]

This works great on my tests. Just left a comment regarding smaller viewports.

[mmtr]

Tested a variety of scenarios in both Simple and Atomic sites, and everything worked as espected. Nice job, @BogdanUngureanu!

Feedback has been addressed

[github-actions]

Great news! One last step: head over to your WordPress.com diff, D61647-code, and commit it.
Once you've done so, come back to this PR and add a comment with your changeset ID.

Thank you!

[BogdanUngureanu]

Deployed on r226120-wpcom