Skip to content

General: update required node version to v16.13.2 #22354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jeherve merged 4 commits into from
Jan 14, 2022
Merged

General: update required node version to v16.13.2 #22354

jeherve merged 4 commits into from
Jan 14, 2022

Conversation

@jeherve
Copy link
Member

@jeherve jeherve commented Jan 14, 2022

Changes proposed in this Pull Request:

  • Update to the most recent version of Node for all our tooling.

Jetpack product discussion

* Internal reference: p3btAN-1D8-p2

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

  • Is CI happy?
  • Does everything build properly?

@jeherve
General: update required node version to v16.13.2
27e1b1e 
Internal reference: p3btAN-1D8-p2
@jeherve jeherve requested a review from a team as a code owner January 14, 2022 15:44
@jeherve jeherve added this to the jetpack/10.6 milestone Jan 14, 2022
@jeherve jeherve self-assigned this Jan 14, 2022
@matticbot
Copy link
Contributor

matticbot commented Jan 14, 2022

Caution: This PR has changes that must be merged to WordPress.com
Hello jeherve! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D73084-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@github-actions github-actions bot added [Package] Lazy Images This package no longer exists in the monorepo. [Package] My Jetpack [Package] Search Contains core Search functionality for Jetpack and Search plugins [Plugin] Backup A plugin that allows users to save every change and get back online quickly with one-click restores. [Plugin] Boost A feature to speed up the site and improve performance. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Search A plugin to add an instant search modal to your site to help visitors find content faster. [Tools] Development CLI The tools/cli to assist during JP development. Actions GitHub actions used to automate some of the work around releases and repository management E2E Tests RNA labels Jan 14, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jan 14, 2022 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

Jetpack plugin:

  • Next scheduled release: February 1, 2022.
  • Scheduled code freeze: January 24, 2022.

Backup plugin:

  • Next scheduled release: February 1, 2022.
  • Scheduled code freeze: January 24, 2022.

Boost plugin:

  • Next scheduled release: January 31, 2022.
  • Scheduled code freeze: January 24, 2022.

Search plugin:

  • Next scheduled release: February 1, 2022.
  • Scheduled code freeze: January 24, 2022.

@jeherve jeherve added [Status] Needs Review This PR is ready for review. and removed [Status] In Progress labels Jan 14, 2022
kraftbj
kraftbj requested changes Jan 14, 2022
View reviewed changes
Copy link
Contributor

@kraftbj kraftbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 14.x branch also had a security release shipped. Should we bump that as well? (all my inline comments are about that).

@kraftbj kraftbj added [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. and removed [Status] Needs Review This PR is ready for review. labels Jan 14, 2022
@jeherve @kraftbj
Update old node version too
0122cee 
Co-authored-by: Brandon Kraft <[email protected]>
@jeherve jeherve added [Status] Needs Review This PR is ready for review. and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Jan 14, 2022
@jeherve jeherve merged commit 35cfa36 into master Jan 14, 2022
@jeherve jeherve deleted the update/node-version-16132 branch January 14, 2022 17:19
@github-actions
Copy link
Contributor

github-actions bot commented Jan 14, 2022

Great news! One last step: head over to your WordPress.com diff, D73084-code, and commit it.
Once you've done so, come back to this PR and add a comment with your changeset ID.

Thank you!

@jeherve
Copy link
Member Author

jeherve commented Jan 14, 2022

r238239-wpcom

@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Jan 14, 2022
@jeherve jeherve mentioned this pull request Jan 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kraftbj kraftbj kraftbj approved these changes

@anomiex anomiex anomiex approved these changes

Assignees

@jeherve jeherve

Labels

[Action] Repo Gardening Github Action: manage PR and issues in your Open Source project [Action] Required Review Actions GitHub actions used to automate some of the work around releases and repository management E2E Tests General [JS Package] Analytics [JS Package] API [JS Package] Babel Plugin Replace Textdomain [JS Package] Base Styles [JS Package] Components [JS Package] Config [JS Package] Connection [JS Package] Eslint Changed [JS Package] Eslint Config Target Es [JS Package] I18n Check Webpack Plugin [JS Package] I18n Loader Webpack Plugin [JS Package] IDC [JS Package] Licensing [JS Package] Partner Coupon [JS Package] Remove Asset Webpack Plugin [JS Package] Storybook [JS Package] Webpack Config [Package] Admin Ui [Package] Connection UI This package no longer exists in the monorepo. [Package] Identity Crisis This package no longer exists in the monorepo. It was merged into [Package] Connection. [Package] Jitm [Package] Lazy Images This package no longer exists in the monorepo. [Package] My Jetpack [Package] Search Contains core Search functionality for Jetpack and Search plugins [Plugin] Backup A plugin that allows users to save every change and get back online quickly with one-click restores. [Plugin] Boost A feature to speed up the site and improve performance. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Search A plugin to add an instant search modal to your site to help visitors find content faster. RNA [Tools] Development CLI The tools/cli to assist during JP development. Touches WP.com Files [Type] Janitorial

Projects

None yet

Milestone

jetpack/10.6

Development

Successfully merging this pull request may close these issues.

5 participants

@jeherve @matticbot @kraftbj @anomiex