Skip to content

Move gutenberg-base-styles file to js-packages/base-styles #23817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kraftbj merged 7 commits into from
Apr 15, 2022
Merged

Move gutenberg-base-styles file to js-packages/base-styles #23817

kraftbj merged 7 commits into from
Apr 15, 2022

Conversation

@mkm119
Copy link
Contributor

@mkm119 mkm119 commented Apr 6, 2022

Fixes #

Changes proposed in this Pull Request:

Moved gutenberg-base-styles.scss file to js-packages/base-styles and updated its imports in the Jetpack plugin directory

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Make sure pnpm build-extensions runs fine
  • Checkout master on your local or proxy site.
  • Create a new post and a couple of blocks from this list: business-hours, contact-form, donations, instagram-gallery, slideshow or one of the other components touched in this PR
  • Pull this branch and open the saved draft post. Everything should be looking as it was earlier.

@matticbot
Copy link
Contributor

matticbot commented Apr 6, 2022

Caution: This PR has changes that must be merged to WordPress.com
Hello mkm119! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D78277-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@mkm119 mkm119 requested a review from a team April 6, 2022 11:10
@github-actions github-actions bot added [Plugin] Boost A feature to speed up the site and improve performance. [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Plugin] Social Issues about the Jetpack Social plugin [Plugin] Starter Plugin labels Apr 8, 2022
@pablinos pablinos force-pushed the move/gutenber-base-styles branch from b952df6 to 28de9e6 Compare April 10, 2022 21:20
danielpost
danielpost previously approved these changes Apr 11, 2022
View reviewed changes
@pablinos pablinos added [Status] Needs Review This PR is ready for review. and removed [Status] Needs Team Review Obsolete. Use Needs Review instead. labels Apr 11, 2022
@pablinos pablinos force-pushed the move/gutenber-base-styles branch from 28de9e6 to 94cc5a3 Compare April 12, 2022 06:57
bindlegirl
bindlegirl previously approved these changes Apr 13, 2022
View reviewed changes
@bindlegirl
Copy link
Contributor

bindlegirl commented Apr 13, 2022

Tested on my local site with several blocks (business hours, videopress, donations, contact form). LGTM.

@kraftbj kraftbj added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Apr 13, 2022
@kraftbj kraftbj merged commit d2d62ec into master Apr 15, 2022
@kraftbj kraftbj deleted the move/gutenber-base-styles branch April 15, 2022 15:48
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Apr 15, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 15, 2022

Great news! One last step: head over to your WordPress.com diff, D78277-code, and deploy it.
Once you've done so, come back to this PR and add a comment with your changeset ID.

Thank you!

@kraftbj
Copy link
Contributor

kraftbj commented Apr 15, 2022

r243800-wpcom

This was referenced Apr 20, 2022
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kraftbj kraftbj kraftbj approved these changes

@bindlegirl bindlegirl bindlegirl left review comments

+1 more reviewer

@danielpost danielpost danielpost left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

[Block] Ad [Block] Business Hours [Block] Contact Form Form block (also see Contact Form label) [Block] Contact Info [Block] Dialogue [Block] Donations [Block] GIF [Block] Latest Instagram Posts [Block] Mailchimp [Block] Map [Block] Markdown [Block] OpenTable [Block] Paid Content aka Premium Content [Block] Pay With Paypal aka Simple Payments [Block] Payments aka Unified Intro [Block] Podcast Player [Block] Slideshow [Block] Star Rating [Block] Story [Block] Tiled Gallery [Block] VideoPress [Extension] Publicize Block editor plugin [Extension] SEO [JS Package] Base Styles [JS Package] Components [JS Package] Connection [JS Package] IDC [JS Package] Licensing [JS Package] Partner Coupon [Package] My Jetpack [Package] Search Contains core Search functionality for Jetpack and Search plugins [Plugin] Backup A plugin that allows users to save every change and get back online quickly with one-click restores. [Plugin] Boost A feature to speed up the site and improve performance. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Plugin] Social Issues about the Jetpack Social plugin [Plugin] Starter Plugin RNA Touches WP.com Files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@mkm119 @matticbot @bindlegirl @kraftbj @danielpost @pablinos