-
Notifications
You must be signed in to change notification settings - Fork 846
Google Fonts: Enqueue fonts used in block and Global Styles #23958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Jetpack plugin:
|
|
Thank you! Left some comments in #23810 (comment) |
sdixon194
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had to do some fixing up with the versions, but this works for me 👍
TestingI tested by applying RequirementsBlock Settings
Global Styles Block-Level Settings
Global Styles
Browsers
|
| * @return void | ||
| */ | ||
| public static function enqueue_global_styles_fonts() { | ||
| if ( is_admin() || ! function_exists( 'wp_enqueue_webfont' ) ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-blocking: This might be a silly question, but would you mind explaining the is_admin() condition here? I thought that we wanted to enqueue all fonts in the site editor? I'm assuming that it's already being done elsewhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Answering now for posterity (sorry I missed this initially!): this is because the all the fonts are already enqueued in wp-admin views (at least in the editor) by Gutenberg, so there's no need to run this function in that context.
Changes proposed in this Pull Request:
Jetpack product discussion
n/a
Does this pull request change what data or activity we track or use?
No.
Testing instructions: