Skip to content

[RNMobile] Address failing mobile tests #24020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kraftbj merged 11 commits into from
Apr 21, 2022
Merged

[RNMobile] Address failing mobile tests #24020

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
0b08331
Remove unnecessary import
SiobhyB Apr 20, 2022
1b18759
Add changelog entry
SiobhyB Apr 20, 2022
e24c019
Merge branch 'rnmobile/update-path-to-base-styles' of https://github.…
SiobhyB Apr 20, 2022
dae0358
Add changelog entry
SiobhyB Apr 20, 2022
588ae21
[not verified] Revert "Add changelog entry"
SiobhyB Apr 20, 2022
916de5e
Merge branch 'rnmobile/update-path-to-base-styles' of https://github.…
SiobhyB Apr 20, 2022
188f200
Merge branch 'master' into rnmobile/update-path-to-base-styles
SiobhyB Apr 20, 2022
537d0ed
[not verified] Revert "Remove unnecessary import"
SiobhyB Apr 20, 2022
4041023
Update to new base styles path
SiobhyB Apr 20, 2022
8879342
Remove unnecessary import
SiobhyB Apr 20, 2022
deeec30
Recreate icons file to resolve test failure
SiobhyB Apr 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions projects/plugins/jetpack/changelog/fix-conflict-with-rnmobile-build
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: other

Remove code in native files that was causing the rnmobile build to fail.
2 changes: 0 additions & 2 deletions projects/plugins/jetpack/extensions/blocks/contact-info/style.native.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
@import '@automattic/jetpack-base-styles/gutenberg-base-styles';

.placeholder {
color: $gray;
}
Expand Down
19 changes: 19 additions & 0 deletions projects/plugins/jetpack/extensions/shared/icons.native.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
.jetpack-gutenberg-social-icon {
fill: $gray-700;

&.is-facebook {
fill: var( --color-facebook );
}
&.is-twitter {
fill: var( --color-twitter );
}
&.is-linkedin {
fill: var( --color-linkedin );
}
&.is-tumblr {
fill: var( --color-tumblr );
}
&.is-google {
fill: var( --color-gplus );
}
}