Skip to content

Conversation

@gmjuhasz
Copy link
Contributor

Fixes small bug introduced in #26253

Changes proposed in this Pull Request:

This is a quick PR to fix a bug with the picing-table design, where the divider between rows is not appearing on small screens

  • Added left and right props to retain the width of the divider

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?

Jetpack product discussion

p1664203272317609-slack-C02JJ910CNL

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

  • Fire up storybook with running npm run storybook:dev from the js-packages/storybook folder.
  • Divider should be present on small screens as well

@gmjuhasz gmjuhasz requested a review from a team September 26, 2022 15:36
@gmjuhasz gmjuhasz self-assigned this Sep 26, 2022
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello gmjuhasz! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D88499-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2022

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Sep 26, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2022

Are you an Automattician? You can now test your Pull Request on WordPress.com. On your sandbox, run bin/jetpack-downloader test jetpack fix/pricing-table-divider to get started. More details: p9dueE-5Nn-p2

@gmjuhasz gmjuhasz added the [Status] Needs Team Review Obsolete. Use Needs Review instead. label Sep 26, 2022
@danielpost danielpost enabled auto-merge (squash) September 26, 2022 18:50
Copy link
Contributor

@pablinos pablinos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving

@danielpost danielpost merged commit 23f5cf9 into trunk Sep 27, 2022
@danielpost danielpost deleted the fix/pricing-table-divider branch September 27, 2022 06:58
@github-actions github-actions bot removed [Status] Needs Team Review Obsolete. Use Needs Review instead. [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Sep 27, 2022
@github-actions
Copy link
Contributor

Great news! One last step: head over to your WordPress.com diff, D88499-code, and deploy it.
Once you've done so, come back to this PR and add a comment with your SVN changeset ID (e.g. r12345-wpcom).

Thank you!

@spsiddarthan
Copy link
Contributor

r253248-wpcom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants