Skip to content

Conversation

@oskosk
Copy link
Contributor

@oskosk oskosk commented Sep 26, 2022

Follow-up to #26408

Changes proposed in this Pull Request:

  • Moves NewPricingComponent and NewPricingComponent definition outside UpsellPage.
  • Moves newPricingArgs out of UpsellPage body

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?

Jetpack product discussion

No

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Go to a connected site with Jetpack Search without a plan.
  • Navigate to /wp-admin/admin.php?page=jetpack-search
  • Confirm you see the current upsell page with current pricing card
  • Navigate to url /wp-admin/admin.php?page=jetpack-search&new_pricing_202208=1
  • Confirm there is a brand new upsell page

@oskosk oskosk added [Status] In Progress [Plugin] Search A plugin to add an instant search modal to your site to help visitors find content faster. [Package] Search Contains core Search functionality for Jetpack and Search plugins labels Sep 26, 2022
@oskosk oskosk requested a review from a team as a code owner September 26, 2022 19:57
@oskosk oskosk changed the title Search: Factor out OldPricingComponent NewPricingComponent out of UpsellPage component Search: Factor out OldPricingComponent and NewPricingComponent out of UpsellPage component Sep 26, 2022
Base automatically changed from update/upsell_page to trunk September 26, 2022 20:16
@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2022

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ⚠️ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Search plugin:

  • Next scheduled release: October 4, 2022.
  • Scheduled code freeze: September 26, 2022.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2022

Are you an Automattician? You can now test your Pull Request on WordPress.com. On your sandbox, run bin/jetpack-downloader test jetpack udpate/upsell_page-render-pattern to get started. More details: p9dueE-5Nn-p2

@oskosk oskosk force-pushed the udpate/upsell_page-render-pattern branch from 86f30a4 to 66100ce Compare September 26, 2022 20:26
@oskosk oskosk added [Status] Needs Team Review Obsolete. Use Needs Review instead. [Feature] Search For all things related to Search and removed [Status] In Progress labels Sep 26, 2022
@jsnmoon jsnmoon merged commit 5809105 into trunk Sep 26, 2022
@jsnmoon jsnmoon deleted the udpate/upsell_page-render-pattern branch September 26, 2022 22:38
@kraftbj kraftbj removed the [Status] Needs Team Review Obsolete. Use Needs Review instead. label Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Search For all things related to Search [JS Package] Components [Package] Search Contains core Search functionality for Jetpack and Search plugins [Plugin] Search A plugin to add an instant search modal to your site to help visitors find content faster. RNA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants