Skip to content

Conversation

@adimoldovan
Copy link
Member

@adimoldovan adimoldovan commented Sep 27, 2022

Changes proposed in this Pull Request:

There is a new pricing page in place and the old selectors are no longer valid, breaking connection tests.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?

Jetpack product discussion

p1664260931070299-slack-C03QNBQKG73

Does this pull request change what data or activity we track or use?

no

Testing instructions:

  • All e2e tests should pass

@github-actions
Copy link
Contributor

github-actions bot commented Sep 27, 2022

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

@adimoldovan adimoldovan marked this pull request as ready for review September 27, 2022 08:16
@adimoldovan adimoldovan added [Status] Needs Review This PR is ready for review. and removed [Status] In Progress labels Sep 27, 2022
@adimoldovan adimoldovan enabled auto-merge (squash) September 27, 2022 08:18
Copy link
Contributor

@zinigor zinigor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E tests seem to pass in this PR, and the code looks good to me.

@adimoldovan adimoldovan merged commit b7f8e71 into trunk Sep 27, 2022
@adimoldovan adimoldovan deleted the e2e/fix-price-page-selectors branch September 27, 2022 08:50
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Sep 27, 2022
dkmyta pushed a commit that referenced this pull request Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants