Skip to content

Conversation

@retrofox
Copy link
Contributor

Fixes #

Changes proposed in this Pull Request:

  • Components: fix the position of TOS component of the Pricing Table component

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Use storybook
  • Test the PricingTable component
  • Pay attention to the TOS section, changing the viewport width

image

before after
Screen Shot 2022-09-28 at 12 25 43 Screen Shot 2022-09-28 at 12 25 17

@retrofox retrofox added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review This PR is ready for review. [Size] S RNA labels Sep 28, 2022
@retrofox retrofox requested a review from a team September 28, 2022 15:27
@retrofox retrofox self-assigned this Sep 28, 2022
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello retrofox! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D88721-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 28, 2022

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 28, 2022

Are you an Automattician? You can now test your Pull Request on WordPress.com. On your sandbox, run bin/jetpack-downloader test jetpack update/component-product-table-tos-tweak-position to get started. More details: p9dueE-5Nn-p2

@retrofox retrofox requested a review from danielpost September 28, 2022 15:28
Copy link
Contributor

@lhkowalski lhkowalski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it on very different width samples, looking good:

pricing-table-xm-viewport

pricing-table-sm-viewport

pricing-table-md-viewport

pricing-table-lg-viewport

@retrofox retrofox added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Sep 28, 2022
@retrofox retrofox merged commit 8d469f5 into trunk Sep 28, 2022
@retrofox retrofox deleted the update/component-product-table-tos-tweak-position branch September 28, 2022 15:55
@github-actions
Copy link
Contributor

Great news! One last step: head over to your WordPress.com diff, D88721-code, and deploy it.
Once you've done so, come back to this PR and add a comment with your SVN changeset ID (e.g. r12345-wpcom).

Thank you!

@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Sep 28, 2022
@retrofox
Copy link
Contributor Author

r253377-wpcom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[JS Package] Components [Package] VideoPress RNA [Size] S Touches WP.com Files [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants