-
Notifications
You must be signed in to change notification settings - Fork 846
Consent Form Block: Added field to Success page, Email and Feedback View #26878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Caution: This PR has changes that must be merged to WordPress.com |
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Jetpack plugin:
|
|
Are you an Automattician? You can now test your Pull Request on WordPress.com. On your sandbox, run |
samiff
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with a checkbox consent field and both states worked well for me 👍
|
Great news! One last step: head over to your WordPress.com diff, D90037-code, and deploy it. Thank you! |
|
Thank you for the review @samiff. Can I also add you for the WP.com diff D90037 as a reviewer? I've tested it and works as expected. |
|
Approved the diff 👍 |
|
Just noting that the grunion-contact-form was defused in diff D90043 and that this diff D90037 is not needed anymore. I closed the diff. |
Fixes #26875. The initial feature was added in this PR.
Changes proposed in this Pull Request:
email_marketing_consentfield setup is moved to theget_field_idsfunction. The field is set on the first Consent field type.Jetpack product discussion
This issue was discussed in slack with Jetpack developers before implementation. p1665394433939419-slack-jetpack-developers
Does this pull request change what data or activity we track or use?
No.
Testing instructions:
/wp-admin/admin.php?page=jetpack_modulesOn Submission = Show a summary of submitted fieldsSucessful Results