Skip to content

Conversation

@creativecoder
Copy link
Contributor

Follow up to #26680

Changes proposed in this Pull Request:

  • Moves the blogging prompt editor extension to experimental, to make it available on WP.com sites
  • Slightly refactors jetpack_get_daily_blogging_prompts since a timestamp can now be specified

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?

Jetpack product discussion

See #26680

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

  • Be sure the site is connected to WP.com to load Jetpack blocks in the editor
  • Enable beta blocks by adding define( 'JETPACK_EXPERMINENTAL_BLOCKS', true ) (or Settings > Jetpack Constants if you're using jurassic.ninja)
  • Set the site as "having a blog" by doing at least one of the following
    • Set the site_intent option to write
    • Set the front page to show posts in Settings > Reading
    • Set a static page for the posts page in Settings > Reading
  • Create a new post, you should see a writing prompt in the placeholder for the first paragraph
  • Create a new post and add the answer_prompt query param with the prompt id for today as the value (e.g. /wp-admin/post-new.php?answer_prompt=2129), and you should see a writing prompt as a pullquote block, the tag dailyprompt added to the post, and the _jetpack_blogging_prompt_key post meta set to the prompt id.
  • Create a new page or custom post type, and you should not see the writing prompt
  • Open an existing post, and you should not see the writing prompt

@creativecoder creativecoder added the [Status] Needs Review This PR is ready for review. label Nov 18, 2022
@creativecoder creativecoder requested a review from a team November 18, 2022 01:19
@creativecoder creativecoder self-assigned this Nov 18, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2022

Are you an Automattician? You can now test your Pull Request on WordPress.com. On your sandbox, run bin/jetpack-downloader test jetpack update/blogging-prompts-experimental to get started. More details: p9dueE-5Nn-p2

@github-actions github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Nov 18, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2022

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Jetpack plugin:

  • Next scheduled release: December 6, 2022.
  • Scheduled code freeze: November 28, 2022.

@github-actions github-actions bot added [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. and removed [Status] Needs Review This PR is ready for review. labels Nov 18, 2022
@creativecoder creativecoder added [Status] Needs Review This PR is ready for review. [Block] Blogging Prompts and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Nov 18, 2022
roo2
roo2 previously approved these changes Nov 18, 2022
Copy link
Contributor

@roo2 roo2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on jurassic.tube, LGTM. Just need to change the base back to trunk

@roo2 roo2 changed the base branch from try/paragraph-block-writing-prompts to trunk November 21, 2022 00:45
@roo2 roo2 dismissed their stale review November 21, 2022 00:45

The base branch was changed.

@roo2 roo2 changed the base branch from trunk to try/paragraph-block-writing-prompts November 21, 2022 00:51
@roo2
Copy link
Contributor

roo2 commented Nov 21, 2022

oops, sorry, why did I think #26680 was merged already 😅 . So after that's merged, then this will need to have base changed to trunk 😛.

Copy link
Contributor

@coder-karen coder-karen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@coder-karen coder-karen added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Nov 21, 2022
@creativecoder creativecoder merged commit 5b9e8c5 into try/paragraph-block-writing-prompts Nov 21, 2022
@creativecoder creativecoder deleted the update/blogging-prompts-experimental branch November 21, 2022 17:17
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Block] Blogging Prompts [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Status] Needs Test Review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants