Skip to content

Conversation

@millerf
Copy link
Contributor

@millerf millerf commented Dec 21, 2022

Fixes Automattic/wp-calypso#71330

Changes proposed in this Pull Request:

Port https://github.com/artpi/wp-writers-block-block to Jetpack

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

PT: pbOQVh-2Ot-p2

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

  • TBD

@github-actions
Copy link
Contributor

github-actions bot commented Dec 21, 2022

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Dec 21, 2022
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're interested in creating a new package, I would recommend using the Jetpack CLI tool to help you with that, as it will handle all the boilerplate for you.
jetpack cli generate.

That said, I don't know if we need a full Composer package for a standalone block. Is there maybe a post about the feature, where one could learn more about what's in the plans? We may be able to discuss details like that there.

Thank you!

@jeherve jeherve added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Proposal [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack labels Dec 21, 2022
jeherve added a commit that referenced this pull request Dec 21, 2022
Currently in Beta

For more information: #28040
@jeherve
Copy link
Member

jeherve commented Dec 21, 2022

That said, I don't know if we need a full Composer package for a standalone block.

To extend a bit on this and maybe help you with some ideas, I think we could structure this like the other blocks, with the block in extensions/, and the API endpoints in a new file like projects/plugins/jetpack/_inc/lib/core-api/wpcom-endpoints/class-wpcom-rest-api-v2-endpoint-coauthor.php, where we would be able to fetch data from WordPress.com using the API like we do in the other endpoints in that directory right now.

We could get started with a PR using the scaffold CLI tool we have at our disposal, and go from there. Here is an example PR where I've done this to show you what I had in mind: #28043

Let me know what you think.

I also found the PT and added a link to it in this PR, for easier reference.

@millerf
Copy link
Contributor Author

millerf commented Dec 22, 2022

Closing in favor of #28043

@jeherve jeherve closed this Dec 22, 2022
@jeherve jeherve deleted the add/coauthor-plugin branch December 22, 2022 14:13
@github-actions github-actions bot removed the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Status] Proposal [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Port the Coauthor plugin to Jetpack

3 participants