Skip to content

Update paid-newsletters with trunk #28171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
romarioraffington merged 87 commits into from
Jan 4, 2023
Merged

Update paid-newsletters with trunk #28171

romarioraffington merged 87 commits into from
Jan 4, 2023

Conversation

@romarioraffington
Copy link
Contributor

@romarioraffington romarioraffington commented Jan 4, 2023

Fixes #

Changes proposed in this Pull Request:

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Go to '..'

Adnan Haque and others added 30 commits December 21, 2022 11:05
Boost: Fix regenerate admin notice (#28012)
c0d9e50 
* Show regenerate notice only if Critical CSS module is active

* changelog
Boost: Add image guide package (#27952)
116b791 
* Add package image-guide

* [not verified] Attempt to use the image-guide package

* changelog

* Specify a main file in package.json

* Two step build

* Use simpler type syntax since prettier... doesn't like it?

* Build image-guide on boost e2e tests

* changelog

* Setup tests

* Attempt to fix imports

* Change main file

* Fixed monorepo package dependencies

* changelog

* Update package.lock

* Update boost pnpm packages

* Attempt to fix monorepo package version refs

* changelog

* Another attempt to fix failed checks

* changelog

* Update boost packages

* Revert main in package.json

* Change main file

* Fix type imports

* [not verified] Revert "Fix type imports"

This reverts commit 66c2ead.

* Allow heart-of-team to approve PRs for image-guide js package

* Specify main and types files separately

* Import types differently

Co-authored-by: Mark George <[email protected]>
@artpi @n3f
@millerf @romarioraffington @mtias @ice9js @jeherve @kraftbj
Premium Content / Subscriptions: introduce Paid Newsletter functional…
ab1665d 
…ity (#26417)

Co-authored-by: brent <[email protected]>
Co-authored-by: Fabien MILLERAND <[email protected]>
Co-authored-by: Brent Nef <[email protected]>
Co-authored-by: Romario <[email protected]>
Co-authored-by: Matías Ventura <[email protected]>
Co-authored-by: Matias Ventura <[email protected]>
Co-authored-by: MILLER/F <[email protected]>
Co-authored-by: Kuba Birecki <[email protected]>
Co-authored-by: Jeremy Herve <[email protected]>
Co-authored-by: Brandon Kraft <[email protected]>
@thingalon
Add/auto publish for image guide (#28032)
8a1fee9 
Co-authored-by: Mark George <[email protected]>
@lupus2k @candy02058912
Gifting toggle: Update default value based on plan expiration date (#…
7829911 
…27987)

Co-authored-by: Candy Tsai <[email protected]>
@valterlorran
Fix out-of-bounds menus on the admin (#27958)
2a990ef 
* [not verified] Fix the out-of-bounds menu. It also caused the menu to flicker if you positioned the mouse in a specific position

* [not verified] Add the listener in the init funciton

* [not verified] Fix the arrow display

* [not verified] Fix missing spaces and changelog text

* [not verified] Prevent code from running twice

* [not verified] Add explanation for using a fallback for the viewport check

* [not verified] Remove the focus when leave the main element

* [not verified] Use the link height instead of hardcoding it

* [not verified] Checking if the site is atomic through a global variable instead of using a class to do it

Co-authored-by: Valter Lorran <[email protected]>
@jcheringer
Contact Form: Adjust Form placeholder footer links styles (#28008)
a958428 
* Adjust Form placeholder footer links style

* changelog
@jeherve
Internationalization: fix context for translated product name. (#28035)
cace091
@coder-karen
Removing box-sizing:border-box from Base Styles (#28024)
42bdd86
@CGastrell @jeherve
Jetpack: Add responses export modal (#27821)
83c1e8c 
Co-authored-by: Jeremy Herve <[email protected]>
@vedanshujain
Allow supporting merge PRs with changelogger. (#27881)
d6bf946 
* [not verified] Allow supporting merge PRs with changelogger.

* [not verified] Add changelog.

* [not verified] Update version number for CLI.

* [not verified] Upgrade changelogger reference in all plugins.

* [not verified] Add changelogs.

* [not verified] Also add support for default merge message from GH.

* [not verified] Add unit test for supporting merge in changelogger.

* [not verified] Remove unneeded capturing groups and added anchoring.

* [not verified] Apply coding standards.

* [not verified] Remove redundant test.
@dhasilva
VideoPress: Add videopress embed shortcode (#27842)
dc53a7b 
* [not verified] add jetpack_videopress shortcode

* [not verified] move width and height out of poster data

* [not verified] add generated jetpack_videopress shortcode to video details component

* [not verified] changelog

* [not verified] specify the video block

* [not verified] improve shortcode markup

* [not verified] read guid as first unnamed argument

* change shortcode to videopress and override jetpack shortcode

* [not verified] change generated shortcode

* changelog

* fix video url on block by id

* fix versions

* simplify existing shortcode check

* add cover attribute
@jeherve
Blocks: switch to new shared, extracted implementation of Tracks (#27940
c546d3e 
)

Co-authored-by: Derek Smart <[email protected]>
@SiobhyB
Blogging Prompts: Don't display within app webviews (#28023)
7424da0 
If a block is unsupported in the mobile app, a user can still edit it via a web view (known as the "Unsupported Block Editor" or "UBE"). Since the introduction of the blogging/writing prompts on WordPress.com, the block no longer loads within the UBE. The prompts display instead.

This PR fixes that issue by preventing the prompts from displaying if it's detected that the editor is loading from the mobile app.
@retrofox
Fix layout visual issues (#28055)
a25150c 
* my-jetpack: fix Product card layout issue

* fix product card detail layout issue

* fix VideoPress seach layout issue

* fix VideoPress detail input layout issue

* changelog

* fix VideoPress clipboard button layout issue

* bump My Jetpack version
@sdixon194
CLI: Cleanup release command next messages (#28041)
0206d15
@simison
Add new i18n fonts and rename them via filter (#27854)
a3b8bf9
@retrofox @lhkowalski
VideoPress: improve blocks building process (#28025)
3b34d3e 
* Add copy-webpack-plugin dep

* changelog

* re-organize building blocks folders

* copy block.json files when building

* point to buld when registering blocks

* fix file paths in video block def

* fix file paths Video Chapters block def

* exclude src/client files in prod

* Copy extensions index file JSON file to the build directory

* Reference correct extensions index JSON file

* use Assets lib to regiters extensions

* refactor extensions. Add helpers.

* move copy-webpack-plugin to dev deps

* load scritps to handle extendd blocks

* debug() unregistering core/embed videopress

* update deps

Co-authored-by: Luiz Kowalski <[email protected]>
@jcheringer
Contact Form: Update child blocks icons (#28047)
b7ed342 
* Update Form child blocks icons

* changelog
@jeherve
Admin page: avoid warning when disconnecting Jetpack (#28003)
8cf142d
@BogdanUngureanu
Payment blocks: Fix upgrade nudge in the site editor (#27909)
c203b1e 
* Payment blocks: Fix upgrade nudge in the site editor.

* Pass only "ref" from blockProps
@retrofox
VideoPress: remove video editor.js unused file (#28060)
aeb91f4 
* remove unused editor.js file

* changelog
@coder-karen
Revue block: Part 1 of retiring the block - adding a placeholder mess…
4195595 
…age. (#27961)
@jeherve
Subscribe Block: ensure custom button spacing is correct (#28057)
6a567de
@matclayton @dereksmart
Shortcode: Update Mixcloud oEmbed url and fix up typos (#28061)
5cc466c 
Co-authored-by: Derek Smart <[email protected]>
@jboland88
Add review prompt for social plugin (#27917)
09d0676 
* Initial placement of review prompt in post publish panel

* Add ability to dismiss review prompt

* Update the permission check function name

* changelog

* Update conditions for showing the review prompt

* Fix project versions

* Add analytics to review prompt

* Swap out typed URL

* Conditionally load the connection state

* Updates based on feedback, performance improvements

* Fix connection package JS error

* move analytics functionality into an existing hook, fix logic error

* changelog

* Refine conditions for when the review request should show

* Allow review prompt to be disabled via filter, add check for post already shared

* Change method for checking whether post is already shared

* changelog

* Fix meta default for already shared

* version management
@thingalon
Clean up Image-Guide (#28053)
e7f139e 
* Add the image-guide to exclusions from the Jetpack and packages list

* Mark it as non-private for npm publishing

* Remove eslint file, to let the standard monorepo rules in the door

* changelog

* Clean up linting complaints

Co-authored-by: Mark George <[email protected]>
@thingalon
Boost/ignore analytics failures (#28051)
ddc3e82 
* Do not allow analytics errors to break other things

* changelog

Co-authored-by: Mark George <[email protected]>
Boost: Add image guide tracks (#28056)
4bf056e 
* Track image-guide ui toggle

* Track image guide images and page

Signed-off-by: Adnan Haque <[email protected]>

* Add initial state and page impact tracking to image guide

Signed-off-by: Adnan Haque <[email protected]>

* changelog

* Fix build issues

Signed-off-by: Adnan Haque <[email protected]>
@kraftbj
Revert "Add review prompt for social plugin (#27917)" (#28066)
2d822cc 
This reverts commit 09d0676.
@github-actions github-actions bot added [Plugin] Search A plugin to add an instant search modal to your site to help visitors find content faster. [Plugin] Social Issues about the Jetpack Social plugin [Plugin] Starter Plugin [Plugin] Super Cache A fast caching plugin for WordPress. [Plugin] VaultPress [Plugin] VideoPress A standalone plugin to add high-quality VideoPress videos to your site. [Status] Needs Test Review [Tools] Development CLI The tools/cli to assist during JP development. Actions GitHub actions used to automate some of the work around releases and repository management Admin Page React-powered dashboard under the Jetpack menu Compatibility [Feature] Contact Form E2E Tests [Feature] Masterbar WordPress.com Toolbar and Dashboard customizations RNA [Feature] Shortcodes / Embeds Unit Tests [Feature] VideoPress A feature to help you upload and insert videos on your site. [Feature] WPCOM API labels Jan 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2023 •
edited
Loading

Are you an Automattician? You can now test your Pull Request on WordPress.com. On your sandbox, run bin/jetpack-downloader test jetpack trunk to get started. More details: p9dueE-5Nn-p2

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2023 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ⚠️ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • 🔴 Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

🔴 Action required: Please add missing changelog entries for the following projects: projects/js-packages/base-styles, projects/js-packages/shared-extension-utils, projects/packages/changelogger, projects/packages/config, projects/packages/publicize, projects/packages/stats-admin, projects/packages/sync

Use the Jetpack CLI tool to generate changelog entries by running the following command: jetpack changelog add.
Guidelines: /docs/writing-a-good-changelog-entry.md

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

Beta plugin:

  • Next scheduled release: February 7, 2023.
  • Scheduled code freeze: January 30, 2023.

Jetpack plugin:

  • Next scheduled release: February 7, 2023.
  • Scheduled code freeze: January 30, 2023.

Debug Helper plugin:

  • Next scheduled release: February 7, 2023.
  • Scheduled code freeze: January 30, 2023.

Backup plugin:

  • Next scheduled release: January 10, 2023.
  • Scheduled code freeze: January 3, 2023.

Vaultpress plugin:

  • Next scheduled release: February 7, 2023.
  • Scheduled code freeze: January 30, 2023.

Boost plugin:

  • Next scheduled release: February 7, 2023.
  • Scheduled code freeze: January 30, 2023.

Search plugin:

  • Next scheduled release: February 7, 2023.
  • Scheduled code freeze: January 30, 2023.

Social plugin:

  • Next scheduled release: January 10, 2023.
  • Scheduled code freeze: January 3, 2023.

Starter Plugin plugin:

  • Next scheduled release: February 7, 2023.
  • Scheduled code freeze: January 30, 2023.

Protect plugin:

  • Next scheduled release: February 7, 2023.
  • Scheduled code freeze: January 30, 2023.

Videopress plugin:

  • Next scheduled release: February 7, 2023.
  • Scheduled code freeze: January 30, 2023.

Super Cache plugin:

  • Next scheduled release: February 7, 2023.
  • Scheduled code freeze: January 30, 2023.

Jetpack Mu wpcom plugin:

  • Next scheduled release: February 7, 2023.
  • Scheduled code freeze: January 30, 2023.

@github-actions github-actions bot added [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Jan 4, 2023
@romarioraffington romarioraffington changed the title Updated paid-newsletters with trunk Update paid-newsletters with trunk Jan 4, 2023
romarioraffington added a commit that referenced this pull request Jan 4, 2023
@romarioraffington
Revert "Updated paid-newsletters with trunk (#28171)"
3bf8a34 
This reverts commit 4a84d2a.
@romarioraffington romarioraffington mentioned this pull request Jan 4, 2023
Merged
romarioraffington added a commit that referenced this pull request Jan 4, 2023
@romarioraffington
Revert "Updated paid-newsletters with trunk (#28171)" (#28173)
82376f5 
This reverts commit 4a84d2a.
@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Jan 4, 2023
@jeherve jeherve added [Focus] Compatibility Ensuring our products play well with third-parties [Tests] Includes Tests labels Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Actions GitHub actions used to automate some of the work around releases and repository management Admin Page React-powered dashboard under the Jetpack menu [Block] Anchor Fm Anchor.fm integration [Block] Blogging Prompts [Block] Contact Form Form block (also see Contact Form label) [Block] Revue [Block] Subscribe E2E Tests [Extension] Blaze [Extension] Launchpad Save Modal [Extension] Payments [Extension] Post Publish Promote Post Panel [Feature] Contact Form [Feature] Masterbar WordPress.com Toolbar and Dashboard customizations [Feature] Shortcodes / Embeds [Feature] VideoPress A feature to help you upload and insert videos on your site. [Feature] WPCOM API [Focus] Compatibility Ensuring our products play well with third-parties [JS Package] Base Styles [JS Package] Components [JS Package] Connection [JS Package] Image Guide [JS Package] Licensing [JS Package] Partner Coupon [JS Package] Publicize Components [JS Package] Shared Extension Utils [Package] Ad aka WordAds [Package] Blaze [Package] Changelogger [Package] Codesniffer [Package] Config [Package] Connection [Package] Jitm [Package] My Jetpack [Package] Publicize [Package] Search Contains core Search functionality for Jetpack and Search plugins [Package] Stats Admin [Package] Sync [Package] VideoPress [Package] WAF [Plugin] Backup A plugin that allows users to save every change and get back online quickly with one-click restores. [Plugin] Beta For serving live branches and the beta versions. https://github.com/automattic/jetpack-beta [Plugin] Boost A feature to speed up the site and improve performance. [Plugin] Debug Helper Debug Tools plugin [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Plugin] Search A plugin to add an instant search modal to your site to help visitors find content faster. [Plugin] Social Issues about the Jetpack Social plugin [Plugin] Starter Plugin [Plugin] Super Cache A fast caching plugin for WordPress. [Plugin] VaultPress [Plugin] VideoPress A standalone plugin to add high-quality VideoPress videos to your site. RNA [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. [Status] Needs Test Review [Tests] Includes Tests [Tools] Development CLI The tools/cli to assist during JP development. Unit Tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.