-
Notifications
You must be signed in to change notification settings - Fork 846
Social Menu: add regex option to service detection in menu. #28172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Up until now, social menu items would only rely on host names (e.g. amazon.fr) to detect whether a specific menu item should use a specific icon. This works well, but isn't very flexible. It's especially problematic for services that typically either have lots of different TLDs, or services that use different domain names. With this commit, you should now be able to provide either a host name, just like before and ensuring backwards compatibility for folks who have customized that feature on their end, as well as regex for more advanced matching.
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Jetpack plugin:
|
|
Are you an Automattician? You can now test your Pull Request on WordPress.com. On your sandbox, run |
Fixes #10338 This is a first implementation, that we can revisit once #28172 is merged. For now, it detects some of the most popular instances of Mastodon (pulled from https://instances.social/ plus a few others that I know are popular in the WordPress community) and uses the Mastodon icon there. It's not perfect since we cannot possibly detect all instances of Mastodon, but that's a start.
projects/plugins/jetpack/modules/theme-tools/social-menu/icon-functions.php
Outdated
Show resolved
Hide resolved
See #28172 (comment) Co-authored-by: Sergey Mitroshin <[email protected]>
sergeymitr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests well 👍
Changes proposed in this Pull Request:
Up until now, social menu items would only rely on host names (e.g. amazon.fr) to detect whether a specific menu item should use a specific icon.
This works well, but isn't very flexible. It's especially problematic for services that typically either have lots of different TLDs, or services that use different domain names.
With this commit, you should now be able to provide either a host name, just like before and ensuring backwards compatibility for folks who have customized that feature on their end, as well as regex for more advanced matching.
In future PRs, I'm hoping to use this new flexibility to add support for more services.
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
jetpack.comfor example.