Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
63 commits
Select commit Hold shift + click to select a range
4ab1d21
PoC: new Dropdown block
jcheringer Dec 19, 2022
2bad136
changelog
jcheringer Dec 19, 2022
0cb2909
Code clean up
jcheringer Dec 19, 2022
37fe238
Organizing and cleaning up the code a bit
jcheringer Dec 22, 2022
19daa5f
Dropdown editor improvements
jcheringer Dec 22, 2022
298da3d
Scripts improvement
jcheringer Dec 22, 2022
d2d604a
Adjust Dropdown toggle label logic
jcheringer Dec 22, 2022
558a240
Layout improvements
jcheringer Dec 22, 2022
2d59686
Merge remote-tracking branch 'origin/trunk' into update/form-dropdown
jcheringer Dec 23, 2022
00ba948
Observe content changes to generate style variables
jcheringer Dec 23, 2022
98eaf6d
Code clean up
jcheringer Dec 23, 2022
b1f50db
Fix tests
jcheringer Dec 23, 2022
bf52f89
Style improvements
jcheringer Dec 23, 2022
4b03fe9
Steal font-family from input fields
jcheringer Dec 23, 2022
2537712
Sync Dropdown placeholder text
jcheringer Dec 23, 2022
5b99018
Style adjustments
jcheringer Jan 2, 2023
2b28192
Fix tests
jcheringer Jan 2, 2023
9a2ce18
Fix Dropdown background color
jcheringer Jan 3, 2023
f5de55e
Fix Dropdown width issue
jcheringer Jan 3, 2023
2b18b4c
Add chevron animation
jcheringer Jan 3, 2023
91e41a4
Fix tests
jcheringer Jan 3, 2023
f099adc
Include jQuery UI CSS file
jcheringer Jan 3, 2023
bf1f312
Update changelog description
jcheringer Jan 3, 2023
a81487f
Adjust chevron size in the Editor
jcheringer Jan 3, 2023
c533572
Adjust Dropdown border and add some shadow to the popover
jcheringer Jan 3, 2023
751d5ce
Adjust Dropdown popover shadow
jcheringer Jan 3, 2023
f344c27
Refactor form-styles to remove jQuery dependency
jcheringer Jan 5, 2023
d3b870b
Update jQuery UI to use only necessary styles
jcheringer Jan 5, 2023
f8e8dd7
Refactor validateFormWrapper function into a hook
jcheringer Jan 5, 2023
1ba4d37
Making the linter happy
jcheringer Jan 5, 2023
fd74a7c
Limite Dropdown popover height
jcheringer Jan 5, 2023
a9e1140
Handle style variations in the frontend
jcheringer Jan 6, 2023
830c67b
Fix label position for non-empty fields
jcheringer Jan 9, 2023
193495f
[not verified] Merge remote-tracking branch 'origin/trunk' into add/f…
jcheringer Jan 9, 2023
671ddbf
changelog
jcheringer Jan 9, 2023
66999d7
Create outlined style for the Editor
jcheringer Jan 10, 2023
884f7cf
Adjust Animated style variation in the frontend
jcheringer Jan 10, 2023
ea494ec
Adjust Animated style variation in the Editor
jcheringer Jan 11, 2023
115fc70
Adjust textarea label position for the Outlined variation
jcheringer Jan 11, 2023
576e79a
General adjustments
jcheringer Jan 11, 2023
dfa1430
Adjust the Below style variation in the Editor
jcheringer Jan 11, 2023
bdc384f
Increase CSS specificity for input fields in the Editor
jcheringer Jan 13, 2023
dbb775f
General style improvements
jcheringer Jan 13, 2023
9be7504
Outlined variation style improvements
jcheringer Jan 13, 2023
53d230a
Adjust fields border
jcheringer Jan 16, 2023
a28708d
Single and Multiple-choice fields adjustments
jcheringer Jan 16, 2023
e53e879
Increase space between the label and the text in the Animated style
jcheringer Jan 16, 2023
48a8127
Fix unit tests
jcheringer Jan 16, 2023
216c063
Styles finetuning
jcheringer Jan 17, 2023
580cdba
Fix label placement on textareas
jcheringer Jan 17, 2023
2edb125
Fix unit tests
jcheringer Jan 17, 2023
66eaa3f
Form: Add loading state (#28473)
jcheringer Jan 23, 2023
dd1a6f7
Merge remote-tracking branch 'origin/trunk' into add/form-style-varia…
jcheringer Jan 23, 2023
91a4575
Attempt to fix Firefox style switch issue
jcheringer Jan 25, 2023
3c1c582
Allow changing field placeholder from within the field
jcheringer Jan 25, 2023
a587ef2
Merge remote-tracking branch 'origin/trunk' into add/form-style-varia…
jcheringer Jan 25, 2023
7c3fd60
Merge remote-tracking branch 'origin/trunk' into add/form-style-varia…
sdixon194 Jan 26, 2023
e60c4a9
Remove unnecessary files
jcheringer Jan 26, 2023
ec6579d
Merge remote-tracking branch 'origin/trunk' into add/form-style-varia…
jcheringer Jan 27, 2023
7331c13
Ajust style variations to work with user-defined styles
jcheringer Jan 27, 2023
7d2f470
Adjust style variations to work with user-defined styles
jcheringer Jan 31, 2023
8a3ec7e
Attempt to fix CSS build side-effect
jcheringer Jan 31, 2023
9fc97ed
Remove loading effect from the editor
jcheringer Feb 3, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Allow changing field placeholder from within the field
  • Loading branch information
jcheringer committed Jan 25, 2023
commit 3c1c582aa4a037a7521e597323f5a396a087d95e
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { useEffect } from '@wordpress/element';
import classnames from 'classnames';
import { isEmpty, isNil, noop } from 'lodash';
import { isEmpty, isNil } from 'lodash';
import { useFormStyle } from '../util/form';
import JetpackFieldControls from './jetpack-field-controls';
import JetpackFieldLabel from './jetpack-field-label';
Expand Down Expand Up @@ -42,7 +42,11 @@ export default function JetpackFieldTextarea( props ) {
setAttributes={ setAttributes }
style={ formStyle }
/>
<textarea className="jetpack-field__textarea" value={ placeholder } onChange={ noop } />
<textarea
className="jetpack-field__textarea"
value={ placeholder }
onChange={ e => setAttributes( { placeholder: e.target.value } ) }
/>
</div>

<JetpackFieldControls
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { createHigherOrderComponent } from '@wordpress/compose';
import { addFilter } from '@wordpress/hooks';
import classnames from 'classnames';
import { isEmpty, noop } from 'lodash';
import { isEmpty } from 'lodash';
import { useFormStyle } from '../util/form';
import JetpackFieldControls from './jetpack-field-controls';
import JetpackFieldLabel from './jetpack-field-label';
Expand Down Expand Up @@ -39,7 +39,7 @@ export default function JetpackField( props ) {
type="text"
className="jetpack-field__input"
value={ placeholder }
onChange={ noop }
onChange={ e => setAttributes( { placeholder: e.target.value } ) }
/>
</div>

Expand Down