Skip to content

Protect: Round ProgressBar percentage values #28273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nateweller merged 4 commits into from
Jan 11, 2023
Merged

Protect: Round ProgressBar percentage values #28273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
13f68a4
Prevent ProgressBar from displaying decimal percentages
nateweller Jan 10, 2023
ea50489
changelog
nateweller Jan 10, 2023
096a315
Use ceil instead of floor
nateweller Jan 10, 2023
bba0829
Update projects/plugins/protect/src/js/components/progress-bar/index.jsx
nateweller Jan 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions projects/plugins/protect/changelog/fix-protect-progress-bar-decimals
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: fixed

Round percentage values in progress bar component
2 changes: 1 addition & 1 deletion projects/plugins/protect/src/js/components/progress-bar/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ const ProgressBar = ( { className, total = 100, value } ) => {
}

// The percentage should not be allowed to be more than 100
const progress = Math.min( ( value / total ) * 100, 100 );
const progress = Math.min( Math.round( ( value / total ) * 100 ), 100 );

const style = {
width: `${ progress }%`,
Expand Down