Skip to content

Conversation

@creativecoder
Copy link
Contributor

Proposed changes:

  • Removes the placeholder writing prompt and related setting
  • Updates the editor extension when the answer_prompt query param is used to fetch the prompt by id, so that we can support older links from notifications or emails.

Part of Automattic/wp-calypso#71938

Requires D97676-code

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

pe7F0s-uo-p2

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

@github-actions
Copy link
Contributor

Are you an Automattician? The PR will need to be tested on WordPress.com. This comment will be updated with testing instructions as soon the build is complete.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 12, 2023

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Jetpack plugin:

  • Next scheduled release: February 7, 2023.
  • Scheduled code freeze: January 31, 2023.

@creativecoder
Copy link
Contributor Author

Closing this... it looks like we'll be going a different direction with the editor extension (potentially with a dedicated writing prompt block), so I'll break out the setting/placeholder removal changes from here into a new, smaller PR.

@creativecoder
Copy link
Contributor Author

I've spun out PR #28387 with the placeholder prompt removal and tag addition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants