Skip to content

Allow Avengers to Approve CRM Code #28348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sdixon194 merged 2 commits into from
Jan 13, 2023
Merged

Allow Avengers to Approve CRM Code #28348

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb40182
Update required-review list
sdixon194 Jan 13, 2023
37e6692
Add to pnpm and composer lockfile list (and alphabetize the teams)
sdixon194 Jan 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions .github/files/required-review.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,12 @@
teams:
# Unfortunately this list need to be maintaned manually...
# yamato-backup-and-security is the group that consists of both yamato-scan and yamato-backup teams.
- jetpack-approvers
- yamato-backup-and-security
- avengers
- heart-of-gold
- jetpack-approvers
- jetpack-reach
- red
- yamato-backup-and-security

# Jetpack Approvers review the Jetpack plugin and all packages, except for those with specific team ownership.
- name: Jetpack and packages
Expand All @@ -41,6 +42,19 @@
teams:
- jetpack-approvers


# The Scan team reviews changes to the protect plugin, the WAF package, etc,
# and can add dependencies to the monorepo's lock file.
- name: CRM
paths:
- 'projects/plugins/crm/**'
- '!projects/plugins/*/composer.lock'
- '!projects/plugins/*/composer.json'
- '!projects/plugins/*/changelog/*'
teams:
- avengers
- jetpack-approvers

# The Backup team reviews changes to the VaultPress and Backup plugin,
# and can add dependencies to the monorepo's lock file.
- name: VaultPress & Backup
Expand Down