Skip to content

Conversation

@millerf
Copy link
Contributor

@millerf millerf commented Jan 26, 2023

Fixes @fgiannar comment

Does this pull request change what data or activity we track or use?

No

Proposed changes:

  • Sanitize endpoints inputs

Testing instructions

  • Deploy to your WPCOM sandbox.
  • Make sure the AI blocks are still working

Screenshot 2023-01-26 at 11 16 36

@millerf millerf self-assigned this Jan 26, 2023
@github-actions github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Jan 26, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 26, 2023

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Jetpack plugin:

  • Next scheduled release: February 7, 2023.
  • Scheduled code freeze: January 31, 2023.

@millerf millerf added [Feature] WPCOM API [Status] Needs Review This PR is ready for review. [Status] Needs Team Review Obsolete. Use Needs Review instead. [Block] AI Image [Block] AI Paragraph and removed [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Jan 26, 2023
@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Jan 26, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 26, 2023

Are you an Automattician? You can now test your Pull Request on WordPress.com. On your sandbox, run

bin/jetpack-downloader test jetpack add/sanitize-openai-input

to get started. More details: p9dueE-5Nn-p2

@github-actions github-actions bot added [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ and removed [Status] Needs Review This PR is ready for review. labels Jan 26, 2023
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we should be able to also rely on a sanitize_callback key in our argument definition to sanitize the request's parameter. It may be worth giving it a try.

@millerf millerf removed the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Jan 26, 2023
@millerf
Copy link
Contributor Author

millerf commented Jan 26, 2023

sanitize_callback

Thanks for such a quick feedback. Let me check...

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Jan 26, 2023
@millerf millerf removed the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Jan 26, 2023
@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Jan 26, 2023
@artpi artpi removed the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Jan 26, 2023
@artpi
Copy link
Contributor

artpi commented Jan 26, 2023

I changed the description because @millerf continually edits it in a way that does not match the bot expectations.

Copy link
Contributor

@artpi artpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, works

@artpi artpi requested a review from jeherve January 26, 2023 18:42
@artpi artpi added [Status] Needs Review This PR is ready for review. and removed [Status] Needs Team Review Obsolete. Use Needs Review instead. labels Jan 26, 2023
@samiff samiff merged commit 6deb52e into trunk Jan 26, 2023
@samiff samiff deleted the add/sanitize-openai-input branch January 26, 2023 20:02
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Jan 26, 2023
@github-actions github-actions bot added this to the jetpack/11.8 milestone Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Block] AI Image [Block] AI Paragraph [Feature] WPCOM API [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants