Skip to content

Conversation

@jeherve
Copy link
Member

@jeherve jeherve commented Jan 31, 2023

Proposed changes:

This effectively reverts #28267. This check should no longer be necessary when D97667-code will be committed.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

  • 1386-gh-dotcom-forge

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

Note
You will not be able to test this until the above diff is committed.

  • Test on a public WoA site
  • Go to the Post list, in wp-admin: wp-admin/edit.php?post_type=post
  • You should see the "Blaze" option when moving your mouse over a post row (if the post is published).
  • Go to https://yoursite.com/wp-admin/admin.php?page=jetpack_modules
  • Disable the JSON API module.
  • Reload the post list in wp-admin.
  • The Blaze option should still be there.
  • Click on one of the links.
  • Ensure the Calypso page loads fully.

This should no longer be necessary when D97667-code will be committed.
@jeherve jeherve added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Pri] Normal [Status] Blocked / Hold [Package] Blaze labels Jan 31, 2023
@jeherve jeherve self-assigned this Jan 31, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 31, 2023

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 31, 2023

Are you an Automattician? You can now test your Pull Request on WordPress.com. On your sandbox, run

bin/jetpack-downloader test jetpack rm/blaze-json-api-gate

to get started. More details: p9dueE-5Nn-p2

@jeherve jeherve added [Status] Needs Review This PR is ready for review. and removed [Status] Blocked / Hold labels Feb 1, 2023
@jeherve jeherve enabled auto-merge (squash) February 1, 2023 17:38
@jeherve jeherve added this to the jetpack/11.8 milestone Feb 1, 2023
Copy link
Contributor

@zinigor zinigor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the diff was merged, this should be good to go.

@zinigor zinigor added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Feb 1, 2023
@jeherve jeherve merged commit 311a6e0 into trunk Feb 1, 2023
@jeherve jeherve deleted the rm/blaze-json-api-gate branch February 1, 2023 19:46
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Feb 1, 2023
@samiff
Copy link
Contributor

samiff commented Feb 2, 2023

cherry-picked to jetpack/branch-11.8 in new package version automattic/jetpack-blaze v0.5.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Package] Blaze [Pri] Normal [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants