-
Notifications
You must be signed in to change notification settings - Fork 846
Forms: Update package with latest contact-form changes #28752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Are you an Automattician? You can now test your Pull Request on WordPress.com. On your sandbox, run to get started. More details: p9dueE-5Nn-p2 |
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. |
CGastrell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well, and I see no problems on .com ![]()
Part of #28405
Proposed changes:
Other information:
Jetpack product discussion
pcsBup-N3-p2
Does this pull request change what data or activity we track or use?
No
Testing instructions:
Enable the Forms package on your jetpack install by making sure the filter below is added before the contact form module is loaded:
Make sure the package is installed with
jetpack install packages/forms && jetpack install plugins/jetpack, and build the JS bundle withjetpack build packages/forms.You can also test the watch functionality with
jetpack watch packages/forms.Play with the Form block and check if it works as expected.
Make sure to test the latest style changes: #28212 - #27837