Skip to content

Conversation

@jcheringer
Copy link
Contributor

Part of #28405

Proposed changes:

  • Updates package with latest contact-form changes from trunk

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

pcsBup-N3-p2

Does this pull request change what data or activity we track or use?

No

Testing instructions:

Enable the Forms package on your jetpack install by making sure the filter below is added before the contact form module is loaded:

add_filter( 'jetpack_contact_form_use_package', '__return_true' );

Make sure the package is installed with jetpack install packages/forms && jetpack install plugins/jetpack, and build the JS bundle with jetpack build packages/forms.
You can also test the watch functionality with jetpack watch packages/forms.

Play with the Form block and check if it works as expected.
Make sure to test the latest style changes: #28212 - #27837

@jcheringer jcheringer requested a review from ice9js February 3, 2023 19:48
@jcheringer jcheringer self-assigned this Feb 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2023

Are you an Automattician? You can now test your Pull Request on WordPress.com. On your sandbox, run

bin/jetpack-downloader test jetpack update/forms-from-trunk

to get started. More details: p9dueE-5Nn-p2

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2023

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

@jcheringer jcheringer added the [Status] Needs Team Review Obsolete. Use Needs Review instead. label Feb 6, 2023
CGastrell
CGastrell previously approved these changes Feb 6, 2023
Copy link
Contributor

@CGastrell CGastrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well, and I see no problems on .com :shipit:

@jcheringer jcheringer added [Status] Needs Review This PR is ready for review. and removed [Status] Needs Team Review Obsolete. Use Needs Review instead. labels Feb 6, 2023
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Feb 8, 2023
@jcheringer jcheringer merged commit fb1467d into trunk Feb 8, 2023
@jcheringer jcheringer deleted the update/forms-from-trunk branch February 8, 2023 13:10
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants