Skip to content

Conversation

@kraftbj
Copy link
Contributor

@kraftbj kraftbj commented Mar 6, 2023

<-- !--- Provide a general summary of your changes in the Title above -->

Fixes One last time...

Proposed changes:

  • capitalization

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

n/a

Does this pull request change what data or activity we track or use?

n/a

Testing instructions:

  • n/a

@kraftbj kraftbj added [Status] Needs Review This PR is ready for review. [Type] Janitorial labels Mar 6, 2023
@kraftbj kraftbj self-assigned this Mar 6, 2023
@kraftbj kraftbj requested a review from oskosk March 6, 2023 19:58
@kraftbj kraftbj enabled auto-merge (squash) March 6, 2023 19:58
Copy link
Contributor

@oskosk oskosk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions github-actions bot added the Actions GitHub actions used to automate some of the work around releases and repository management label Mar 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2023

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

@kraftbj kraftbj merged commit 3ec40a6 into trunk Mar 6, 2023
@kraftbj kraftbj deleted the update/cs-again branch March 6, 2023 20:02
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Mar 6, 2023
@kraftbj kraftbj mentioned this pull request Mar 6, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Actions GitHub actions used to automate some of the work around releases and repository management [Type] Janitorial

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants